From 46fcf91981c779854db1b041d02ef42722ac80a3 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Wed, 10 Dec 2014 13:02:31 -0800 Subject: [PATCH] Respond to code review comments --- src/harness/fourslash.ts | 1 + src/services/shims.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts index be03b148be0..2d81524bf6d 100644 --- a/src/harness/fourslash.ts +++ b/src/harness/fourslash.ts @@ -167,6 +167,7 @@ module FourSlash { settings.module = ts.ModuleKind.CommonJS; break; default: + ts.Debug.assert(typeof globalOptions[prop] === "undefined" || globalOptions[prop] === "None"); settings.module = ts.ModuleKind.None; break; } diff --git a/src/services/shims.ts b/src/services/shims.ts index 5e4ebaf0d06..a86d1f5231d 100644 --- a/src/services/shims.ts +++ b/src/services/shims.ts @@ -222,7 +222,7 @@ module ts { throw Error("LanguageServiceShimHostAdapter.getCompilationSettings: empty compilationSettings"); return null; } - return JSON.parse(settingsJson); + return JSON.parse(settingsJson); } public getScriptFileNames(): string[] {