From 438650128599e662f700c76306a6f8f6cc4893b0 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Wed, 3 Apr 2024 10:29:27 -0700 Subject: [PATCH] Make unused variable rule a warning, error on warnings for CI (#58059) --- .eslintrc.json | 2 +- Herebyfile.mjs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.eslintrc.json b/.eslintrc.json index 1fdedf0965a..526b03f6060 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -110,7 +110,7 @@ } ], "@typescript-eslint/no-unused-vars": [ - "error", + "warn", { // Ignore: (solely underscores | starting with exactly one underscore) "argsIgnorePattern": "^(_+$|_[^_])", diff --git a/Herebyfile.mjs b/Herebyfile.mjs index 10598bd1e65..8447834a633 100644 --- a/Herebyfile.mjs +++ b/Herebyfile.mjs @@ -538,6 +538,8 @@ export const lint = task({ "--format", formatter, "--report-unused-disable-directives", + "--max-warnings", + "0", ]; if (cmdLineOptions.fix) {