From 422324f0af459438e60e2e31b38715b207addf48 Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Fri, 3 Oct 2014 15:06:04 -0700 Subject: [PATCH] CodeReview feedback. --- src/services/services.ts | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/services/services.ts b/src/services/services.ts index ebea261d41d..36ea451497b 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -1,4 +1,4 @@ - /// +/// /// /// /// @@ -4711,7 +4711,7 @@ module ts { // In order to determine if the user is potentially typing something generic, we use a // weak heuristic where we track < and > tokens. It's a weak heuristic, but should // work well enough in practice. - var inGenericStack = 0; + var angleBracketStack = 0; do { token = scanner.scan(); @@ -4736,19 +4736,18 @@ module ts { token === SyntaxKind.LessThanToken) { // Could be the start of something generic. Keep track of that by bumping // up the current count of generic contexts we may be in. - inGenericStack++; + angleBracketStack++; } - else if (token === SyntaxKind.GreaterThanToken && inGenericStack > 0) { + else if (token === SyntaxKind.GreaterThanToken && angleBracketStack > 0) { // If we think we're currently in something generic, then mark that that // generic entity is complete. - inGenericStack--; + angleBracketStack--; } else if (token === SyntaxKind.AnyKeyword || token === SyntaxKind.StringKeyword || token === SyntaxKind.NumberKeyword || - token === SyntaxKind.BooleanKeyword || - token === SyntaxKind.VoidKeyword) { - if (inGenericStack > 0) { + token === SyntaxKind.BooleanKeyword) { + if (angleBracketStack > 0) { // If it looks like we're could be in something generic, don't classify this // as a keyword. We may just get overwritten by the syntactic classifier, // causing a noisy experience for the user.