microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-17 10:40:34 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #1271 from Microsoft/taggedSigHelpAtEnd

Browse Source 
Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end.
This commit is contained in:
Daniel Rosenwasser
2015-02-12 11:37:32 -08:00
parent 983b9f54fb 3cd0e9feb5
commit 3e8babedcf
5 changed files with 46 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/signatureHelp.ts
View File

@@ -295,8 +295,8 @@ module ts.SignatureHelp {
var tagExpression = <TaggedTemplateExpression>templateExpression.parent;
Debug.assert(templateExpression.kind === SyntaxKind.TemplateExpression);
// If we're just after a template tail, don't show signature help.
if (node.kind === SyntaxKind.TemplateTail && position >= node.getEnd() && !(<LiteralExpression>node).isUnterminated) {
// If we're just after a template tail, don't show signature help.
if (node.kind === SyntaxKind.TemplateTail && !isInsideTemplateLiteral(<LiteralExpression>node, position)) {
return undefined;
}