microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-30 11:24:49 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix missing parentheses in inline variable (#54737)

Browse Source
This commit is contained in:
Maria José Solano
2023-06-26 14:08:59 -07:00
committed by GitHub
parent f762de5220
commit 38575dc015
6 changed files with 144 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/services/refactors/inlineVariable.ts
View File

@@ -20,6 +20,9 @@ import {
isFunctionLike,
isIdentifier,
isInitializedVariable,
isNumericLiteral,
isObjectLiteralExpression,
isPropertyAccessExpression,
isTypeQueryNode,
isVariableDeclarationInVariableStatement,
isVariableStatement,
@@ -228,7 +231,13 @@ function getReplacementExpression(reference: Node, replacement: Expression): Exp
// Functions also need to be parenthesized.
// E.g.: const f = () => {}; f(); -> (() => {})();
if (isFunctionLike(replacement) && isCallLikeExpression(parent)) {
if (isFunctionLike(replacement) && (isCallLikeExpression(parent) || isPropertyAccessExpression(parent))) {
return factory.createParenthesizedExpression(replacement);
}
// Property access of numeric literals and objects need parentheses.
// E.g.: const x = 1; x.toString(); -> (1).toString();
if (isPropertyAccessExpression(parent) && (isNumericLiteral(replacement) || isObjectLiteralExpression(replacement))) {
return factory.createParenthesizedExpression(replacement);
}