CR feedback

This commit is contained in:
Zhengbo Li 2015-05-29 18:03:41 -07:00
parent c597bd63fc
commit 321cfab2d7
2 changed files with 30 additions and 30 deletions

View File

@ -88,7 +88,7 @@ declare module ts.server.protocol {
}
/**
* Arguments for ProjectInfo messages.
* Arguments for ProjectInfoResponse messages.
*/
export interface ProjectInfoRequestArgs {
/**
@ -104,7 +104,7 @@ declare module ts.server.protocol {
/**
* Response message for "projectInfo" request
*/
export interface ProjectInfo {
export interface ProjectInfoResponse {
configFileName: string;
fileNameList?: string[];
}

View File

@ -76,30 +76,30 @@ module ts.server {
}
export module CommandNames {
export var Brace = "brace";
export var Change = "change";
export var Close = "close";
export var Completions = "completions";
export var CompletionDetails = "completionEntryDetails";
export var Configure = "configure";
export var Definition = "definition";
export var Exit = "exit";
export var Format = "format";
export var Formatonkey = "formatonkey";
export var Geterr = "geterr";
export var NavBar = "navbar";
export var Navto = "navto";
export var Occurrences = "occurrences";
export var Open = "open";
export var Quickinfo = "quickinfo";
export var References = "references";
export var Reload = "reload";
export var Rename = "rename";
export var Saveto = "saveto";
export var SignatureHelp = "signatureHelp";
export var TypeDefinition = "typeDefinition";
export var ProjectInfo = "projectInfo";
export var Unknown = "unknown";
export const Brace = "brace";
export const Change = "change";
export const Close = "close";
export const Completions = "completions";
export const CompletionDetails = "completionEntryDetails";
export const Configure = "configure";
export const Definition = "definition";
export const Exit = "exit";
export const Format = "format";
export const Formatonkey = "formatonkey";
export const Geterr = "geterr";
export const NavBar = "navbar";
export const Navto = "navto";
export const Occurrences = "occurrences";
export const Open = "open";
export const Quickinfo = "quickinfo";
export const References = "references";
export const Reload = "reload";
export const Rename = "rename";
export const Saveto = "saveto";
export const SignatureHelp = "signatureHelp";
export const TypeDefinition = "typeDefinition";
export const ProjectInfo = "projectInfo";
export const Unknown = "unknown";
}
module Errors {
@ -339,18 +339,18 @@ module ts.server {
});
}
getProjectInfo(fileName: string, needFileNameList: boolean): protocol.ProjectInfo {
getProjectInfo(fileName: string, needFileNameList: boolean): protocol.ProjectInfoResponse {
fileName = ts.normalizePath(fileName)
let project = this.projectService.getProjectForFile(fileName)
let projectInfo: protocol.ProjectInfo = {
let projectInfoResponse: protocol.ProjectInfoResponse = {
configFileName: project.projectFilename
}
if (needFileNameList) {
projectInfo.fileNameList = project.getFileNameList();
projectInfoResponse.fileNameList = project.getFileNameList();
}
return projectInfo;
return projectInfoResponse;
}
getRenameLocations(line: number, offset: number, fileName: string,findInComments: boolean, findInStrings: boolean): protocol.RenameResponseBody {