microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 12:51:30 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #22251 from jack-williams/jack-williams/no-implicit-symbol-to-string

Browse Source 
Fix #19666: Check for symbol types in template expressions
This commit is contained in:
Mohamed Hegazy
2018-03-30 09:32:11 -07:00
committed by GitHub
parent 849ecdf50a 5338500c05
commit 31c3ef51d3
10 changed files with 201 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/checker.ts
View File

@@ -19684,7 +19684,9 @@ namespace ts {
// A place where we actually *are* concerned with the expressions' types are
// in tagged templates.
forEach(node.templateSpans, templateSpan => {
checkExpression(templateSpan.expression);
if (maybeTypeOfKind(checkExpression(templateSpan.expression), TypeFlags.ESSymbolLike)) {
error(templateSpan.expression, Diagnostics.Type_0_cannot_be_converted_to_type_1, typeToString(esSymbolType), typeToString(stringType));
}
});
return stringType;