From 302c0fc73632faa4e8b01bec8f747de8a175c4e1 Mon Sep 17 00:00:00 2001 From: Gabriela Araujo Britto Date: Mon, 25 Oct 2021 15:41:50 -0700 Subject: [PATCH] check completion kind before calling isclasslikemembercompletion --- src/compiler/checker.ts | 2 +- src/services/completions.ts | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 994ea226144..044e00bc287 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -729,7 +729,7 @@ namespace ts { isDeclarationVisible, isPropertyAccessible, getTypeOnlyAliasDeclaration, - getMemberOverrideModifierStatus: getMemberOverrideModifierStatus, + getMemberOverrideModifierStatus, }; function getResolvedSignatureWorker(nodeIn: CallLikeExpression, candidatesOutArray: Signature[] | undefined, argumentCount: number | undefined, checkMode: CheckMode): Signature | undefined { diff --git a/src/services/completions.ts b/src/services/completions.ts index 62420d6edcd..2d1e874a77f 100644 --- a/src/services/completions.ts +++ b/src/services/completions.ts @@ -635,6 +635,7 @@ namespace ts.Completions { useSemicolons: boolean, options: CompilerOptions, preferences: UserPreferences, + completionKind: CompletionKind, ): CompletionEntry | undefined { let insertText: string | undefined; let replacementSpan = getReplacementSpanForContextToken(replacementToken); @@ -697,7 +698,7 @@ namespace ts.Completions { } } - if (preferences.includeCompletionsWithInsertText && isClassLikeMemberCompletion(symbol, location)) { + if (preferences.includeCompletionsWithInsertText && completionKind === CompletionKind.MemberLike && isClassLikeMemberCompletion(symbol, location)) { ({ insertText, isSnippet } = getEntryForMemberCompletion(host, program, options, preferences, name, symbol, location, contextToken)); } @@ -1164,7 +1165,8 @@ namespace ts.Completions { importCompletionNode, useSemicolons, compilerOptions, - preferences + preferences, + kind, ); if (!entry) { continue;