From 2cbe14e1312296cdb1c8abfa0b81c6fb6932701e Mon Sep 17 00:00:00 2001
From: Mohamed Hegazy <mhegazy@microsoft.com>
Date: Wed, 27 May 2015 10:20:01 -0700
Subject: [PATCH] Respond to code review comments

---
 src/compiler/program.ts            | 2 +-
 src/services/services.ts           | 9 ++++++---
 tests/cases/unittests/transpile.ts | 6 +++---
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/compiler/program.ts b/src/compiler/program.ts
index 4cccc881d40..1db32b95954 100644
--- a/src/compiler/program.ts
+++ b/src/compiler/program.ts
@@ -286,7 +286,7 @@ module ts {
             }
         }
 
-        function getCompilerOptionsDiagnostics(): Diagnostic[]{
+        function getCompilerOptionsDiagnostics(): Diagnostic[] {
             let allDiagnostics: Diagnostic[] = [];
             addRange(allDiagnostics, diagnostics.getGlobalDiagnostics());
             return sortAndDeduplicateDiagnostics(allDiagnostics);
diff --git a/src/services/services.ts b/src/services/services.ts
index ff1e627a241..58155f2a691 100644
--- a/src/services/services.ts
+++ b/src/services/services.ts
@@ -1763,6 +1763,8 @@ module ts {
      * Extra compiler options that will unconditionally be used bu this function are:
      * - isolatedModules = true
      * - allowNonTsExtensions = true
+     * - noLib = true
+     * - noResolve = true
      */
     export function transpile(input: string, compilerOptions?: CompilerOptions, fileName?: string, diagnostics?: Diagnostic[]): string {
         let options = compilerOptions ? clone(compilerOptions) : getDefaultCompilerOptions();
@@ -1772,11 +1774,12 @@ module ts {
         // Filename can be non-ts file.
         options.allowNonTsExtensions = true;
 
-        // We are not returning a lib file when asked, so pass this flag to
-        // avoid reporting a file not found error
+        // We are not returning a sourceFile for lib file when asked by the program, 
+        // so pass --noLib to avoid reporting a file not found error.
         options.noLib = true;
 
-        // Similar to the library, we are not returning any refrenced files
+        // We are not doing a full typecheck, we are not resolving the whole context,
+        // so pass --noResolve to avoid reporting missing file errors.
         options.noResolve = true;
 
         // Parse
diff --git a/tests/cases/unittests/transpile.ts b/tests/cases/unittests/transpile.ts
index 32caad8d05c..eca136649f2 100644
--- a/tests/cases/unittests/transpile.ts
+++ b/tests/cases/unittests/transpile.ts
@@ -7,10 +7,10 @@ module ts {
             let diagnostics: Diagnostic[] = [];
             let result = transpile(input, compilerOptions, "file.ts", diagnostics);
 
-            assert.equal(diagnostics.length, expectedDiagnosticCodes.length);
-            for (let diagnostic of diagnostics) {
-                assert.isTrue(expectedDiagnosticCodes.indexOf(diagnostic.code) >= 0, `Found an unexpected diagnostic: ${ diagnostic.code }`);
+            for (let i = 0; i < expectedDiagnosticCodes.length; i++) {
+                assert.equal(expectedDiagnosticCodes[i], diagnostics[i] && diagnostics[i].code, `Could not find expeced diagnostic.`);
             }
+            assert.equal(diagnostics.length, expectedDiagnosticCodes.length, "Resuting diagnostics count does not match expected");
 
             if (expectedOutput !== undefined) {
                 assert.equal(result, expectedOutput);