microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-09 02:30:15 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Only cache types for object literals with 10 or less properties

Browse Source
This commit is contained in:
Anders Hejlsberg 2017-08-28 16:02:55 -07:00
parent 7118fc5788
commit 28ea53e4f0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/checker.ts
View File

@ -13708,10 +13708,10 @@ namespace ts {
// We used a cached object literal type if the object literal is not the inferred type of a variable
// (otherwise Go To Definition on the variable's members wouldn't work properly), has no methods or
// accessors (we may cause circularities when obtaining the types of those members), has no index
// signatures, is not in a destructuring pattern, doesn't have more than 50 properties, and doesn't
// signatures, is not in a destructuring pattern, doesn't have more than 10 properties, and doesn't
// have property names containing colons (which we use as a separator in the cache key).
if (!isInferredTypeOfVariable(node) && !hasMethodsOrAccessors && !stringIndexInfo && !numberIndexInfo && !inDestructuringPattern &&
propertiesArray.length <= 50 && !forEach(propertiesArray, symbolNameContainsColon)) {
propertiesArray.length <= 10 && !forEach(propertiesArray, symbolNameContainsColon)) {
return getObjectLiteralType(typeFlags, node.symbol, propertiesTable, propertiesArray);
}
const result = makeObjectLiteralType(typeFlags, node.symbol, propertiesTable, stringIndexInfo, numberIndexInfo);