microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-06 20:14:01 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Add 'string' ScriptElementKind (#23821)

Browse Source
This commit is contained in:
Andy 2018-05-07 12:39:00 -07:00 committed by GitHub
parent 05b250691f
commit 2604bb4dd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/completions.ts
View File

@ -81,7 +81,7 @@ namespace ts.Completions {
return { isGlobalCompletion: false, isMemberCompletion: true, isNewIdentifierLocation: completion.hasIndexSignature, entries };
}
case StringLiteralCompletionKind.Types: {
const entries = completion.types.map(type => ({ name: type.value, kindModifiers: ScriptElementKindModifier.none, kind: ScriptElementKind.typeElement, sortText: "0" }));
const entries = completion.types.map(type => ({ name: type.value, kindModifiers: ScriptElementKindModifier.none, kind: ScriptElementKind.string, sortText: "0" }));
return { isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: completion.isNewIdentifier, entries };
}
default:

3
src/services/types.ts
View File

@ -995,6 +995,9 @@ namespace ts {
* <JsxTagName attribute1 attribute2={0} />
*/
jsxAttribute = "JSX attribute",
/** String literal */
string = "string",
}
export const enum ScriptElementKindModifier {

4
tests/baselines/reference/api/tsserverlibrary.d.ts vendored
View File

@ -5021,7 +5021,9 @@ declare namespace ts {
/**
* <JsxTagName attribute1 attribute2={0} />
*/
jsxAttribute = "JSX attribute"
jsxAttribute = "JSX attribute",
/** String literal */
string = "string"
}
enum ScriptElementKindModifier {
none = "",

4
tests/baselines/reference/api/typescript.d.ts vendored
View File

@ -5021,7 +5021,9 @@ declare namespace ts {
/**
* <JsxTagName attribute1 attribute2={0} />
*/
jsxAttribute = "JSX attribute"
jsxAttribute = "JSX attribute",
/** String literal */
string = "string"
}
enum ScriptElementKindModifier {
none = "",

2
tests/cases/fourslash/completionForStringLiteral_details.ts
View File

@ -21,7 +21,7 @@ goTo.marker("path");
verify.completionListContains("other", "other", "", "script");
goTo.marker("type");
verify.completionListContains("a", "a", "", "type");
verify.completionListContains("a", "a", "", "string");
goTo.marker("prop");
verify.completionListContains("x", "(property) I.x: number", "Prop doc ", "property");