microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-11 20:37:46 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Report more "No overload matches this call" errors on call target nodes (#54447)

Browse Source 
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
This commit is contained in:
Mateusz Burzyński
2023-11-30 00:23:09 +01:00
committed by GitHub
parent e9737b893c
commit 24166a4ed8
19 changed files with 68 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/compiler/checker.ts
View File

@@ -33944,6 +33944,19 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}
}
function getErrorNodeForCallNode(callLike: CallLikeExpression): Node {
if (isCallOrNewExpression(callLike)) {
return isPropertyAccessExpression(callLike.expression) ? callLike.expression.name : callLike.expression;
}
if (isTaggedTemplateExpression(callLike)) {
return isPropertyAccessExpression(callLike.tag) ? callLike.tag.name : callLike.tag;
}
if (isJsxOpeningLikeElement(callLike)) {
return callLike.tagName;
}
return callLike;
}
function isPromiseResolveArityError(node: CallLikeExpression) {
if (!isCallExpression(node) || !isIdentifier(node.expression)) return false;
@@ -34267,7 +34280,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
diag = { file, start, length, code: chain.code, category: chain.category, messageText: chain, relatedInformation: related };
}
else {
diag = createDiagnosticForNodeFromMessageChain(getSourceFileOfNode(node), node, chain, related);
diag = createDiagnosticForNodeFromMessageChain(getSourceFileOfNode(node), getErrorNodeForCallNode(node), chain, related);
}
addImplementationSuccessElaboration(candidatesForArgumentError[0], diag);
diagnostics.add(diag);