microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-17 11:24:29 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

single iteration through children array without any array allocation

Browse Source
This commit is contained in:
Noj Vek
2016-01-28 23:29:08 -08:00
parent a116b4c996
commit 238fcbcee9
6 changed files with 94 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
src/compiler/emitter.ts
View File

@@ -1257,21 +1257,66 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
// Children
if (children) {
// build list of valid emittable jsx children
const emittableChildren = children.filter(isJsxChildEmittable);
if (emittableChildren.length > 0) {
// If the only child is non-jsx element, don't put it on a new line
if (emittableChildren.length == 1 && emittableChildren[0].kind !== SyntaxKind.JsxElement && emittableChildren[0].kind !== SyntaxKind.JsxSelfClosingElement) {
write(", ");
emit(emittableChildren[0]);
let firstChild:JsxChild;
let multipleEmittableChildren = false;
for (let i = 0, n = children.length; i < n; ++i) {
let jsxChild = children[i];
if (isJsxChildEmittable(jsxChild)) {
// we need to decide whether to emit in single line or multiple lines as indented list
// store firstChild reference, if we see another emittable child, then emit accordingly
if (!firstChild) {
write(", ");
firstChild = jsxChild;
}
else {
// more than one emittable child, emit indented list
if(!multipleEmittableChildren){
multipleEmittableChildren = true;
increaseIndent();
writeLine();
emit(firstChild);
}
write(", ");
writeLine();
emit(jsxChild);
}
}
}
if (multipleEmittableChildren) {
decreaseIndent();
}
else if (firstChild) {
if (firstChild.kind !== SyntaxKind.JsxElement && firstChild.kind !== SyntaxKind.JsxSelfClosingElement) {
emit(firstChild);
}
// Otherwise build a indented comma separated list
else {
// If the only child is jsx element, put it on a new indented line
increaseIndent();
emitList(emittableChildren, 0, emittableChildren.length, /*multiLine*/ true, /*trailingComma*/ false, /*leadingComma*/ true);
writeLine();
emit(firstChild);
writeLine();
decreaseIndent();
}
}
// const emittableChildren = children.filter(isJsxChildEmittable);
// if (emittableChildren.length > 0) {
// // If the only child is non-jsx element, don't put it on a new line
// if (emittableChildren.length == 1 && emittableChildren[0].kind !== SyntaxKind.JsxElement && emittableChildren[0].kind !== SyntaxKind.JsxSelfClosingElement) {
// write(", ");
// emit(emittableChildren[0]);
// }
// // Otherwise build a indented comma separated list
// else {
// increaseIndent();
// emitList(emittableChildren, 0, emittableChildren.length, /*multiLine*/ true, /*trailingComma*/ false, /*leadingComma*/ true);
// decreaseIndent();
// }
// }
}
// Closing paren