microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-04 21:53:42 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Restore reference change

Browse Source
This commit is contained in:
Ron Buckton 2020-07-29 18:41:05 -07:00
parent 4c90ba9456
commit 21963ce337
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/binder.ts
View File

@ -837,9 +837,8 @@ namespace ts {
function isNarrowableReference(expr: Expression): boolean {
return expr.kind === SyntaxKind.Identifier || expr.kind === SyntaxKind.ThisKeyword || expr.kind === SyntaxKind.SuperKeyword ||
(isPropertyAccessExpression(expr) || isNonNullExpression(expr) || isParenthesizedExpression(expr)) && isNarrowableReference(expr.expression) ||
isElementAccessExpression(expr) && isStringOrNumericLiteralLike(expr.argumentExpression) && isNarrowableReference(expr.expression);
// ||
// isAssignmentExpression(expr) && isNarrowableReference(expr.left);
isElementAccessExpression(expr) && isStringOrNumericLiteralLike(expr.argumentExpression) && isNarrowableReference(expr.expression) ||
isAssignmentExpression(expr) && isNarrowableReference(expr.left);
}
function containsNarrowableReference(expr: Expression): boolean {

10
src/compiler/checker.ts
View File

@ -20131,11 +20131,11 @@ namespace ts {
case SyntaxKind.ParenthesizedExpression:
case SyntaxKind.NonNullExpression:
return isMatchingReference(source, (target as NonNullExpression | ParenthesizedExpression).expression);
// case SyntaxKind.BinaryExpression:
// if (isAssignmentExpression(target)) {
// return isMatchingReference(source, target.left);
// }
// break;
case SyntaxKind.BinaryExpression:
if (isAssignmentExpression(target)) {
return isMatchingReference(source, target.left);
}
break;
}
switch (source.kind) {
case SyntaxKind.Identifier: