From 20f671ede2d9f2eb4cd4088e4b36aeed9bd0472f Mon Sep 17 00:00:00 2001 From: Sheetal Nandi Date: Fri, 14 Sep 2018 11:07:22 -0700 Subject: [PATCH] PR feedback --- src/compiler/program.ts | 4 +++- src/compiler/utilities.ts | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/program.ts b/src/compiler/program.ts index 970689f93c3..d15b5935224 100644 --- a/src/compiler/program.ts +++ b/src/compiler/program.ts @@ -1017,13 +1017,14 @@ namespace ts { // If array of references is changed, we cant resue old program const oldProjectReferences = oldProgram.getProjectReferences(); - if (!arrayIsEqualTo(oldProjectReferences!, projectReferences, projectReferencesIsEqualTo)) { + if (!arrayIsEqualTo(oldProjectReferences!, projectReferences, projectReferenceIsEqualTo)) { return oldProgram.structureIsReused = StructureIsReused.Not; } // Check the json files for the project references const oldRefs = oldProgram.getResolvedProjectReferences(); if (projectReferences) { + // Resolved project referenced should be array if projectReferences provided are array Debug.assert(!!oldRefs); for (let i = 0; i < projectReferences.length; i++) { const oldRef = oldRefs![i]; @@ -1043,6 +1044,7 @@ namespace ts { } } else { + // Resolved project referenced should be undefined if projectReferences is undefined Debug.assert(!oldRefs); } diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts index 51315dbf455..907e921b91f 100644 --- a/src/compiler/utilities.ts +++ b/src/compiler/utilities.ts @@ -249,7 +249,7 @@ namespace ts { sourceFile.resolvedTypeReferenceDirectiveNames.set(typeReferenceDirectiveName, resolvedTypeReferenceDirective); } - export function projectReferencesIsEqualTo(oldRef: ProjectReference, newRef: ProjectReference) { + export function projectReferenceIsEqualTo(oldRef: ProjectReference, newRef: ProjectReference) { return oldRef.path === newRef.path && !oldRef.prepend === !newRef.prepend && !oldRef.circular === !newRef.circular;