microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-15 11:35:42 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Minor cleanup of resolveName for decorators

Browse Source
This commit is contained in:
Ron Buckton 2015-03-19 23:06:38 -07:00
parent 0fb624a58b
commit 2078aff69f
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/compiler/checker.ts
View File

@ -417,24 +417,25 @@ module ts {
}
break;
case SyntaxKind.Decorator:
// Decorators are resolved at the class declaration as that point where they are evaluated in the emit:
// Decorators are resolved at the class declaration. Resolving at the parameter
// or member would result in looking up locals in the method.
//
// function y() {}
// class C {
// method(@y x, y) {} // <-- All references to decorators should occur at the class declaration
// method(@y x, y) {} // <-- decorator y should be resolved at the class declaration, not the parameter.
// }
//
let parent = location.parent;
if (parent && parent.kind === SyntaxKind.Parameter) {
parent = parent.parent;
if (location.parent && location.parent.kind === SyntaxKind.Parameter) {
location = location.parent;
}
if (parent && isClassElement(parent)) {
parent = parent.parent;
}
if (parent) {
lastLocation = location;
location = parent;
continue;
//
// function y() {}
// class C {
// @y method(x, y) {} // <-- decorator y should be resolved at the class declaration, not the method.
// }
//
if (location.parent && isClassElement(location.parent)) {
location = location.parent;
}
break;
}