microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-03-06 21:22:55 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Simplify statSync (#59276)

Browse Source
This commit is contained in:
Jake Bailey 2024-09-26 15:28:28 -07:00 committed by GitHub
parent 5119230083
commit 20746579b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 29 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

91
src/compiler/sys.ts
View File

@ -1484,6 +1484,8 @@ export let sys: System = (() => {
const isMacOs = process.platform === "darwin";
const isLinuxOrMacOs = process.platform === "linux" || isMacOs;
const statSyncOptions = { throwIfNoEntry: false } as const;
const platform: string = _os.platform();
const useCaseSensitiveFileNames = isFileSystemCaseSensitive();
const fsRealpath = !!_fs.realpathSync.native ? process.platform === "win32" ? fsRealPathHandlingLongPath : _fs.realpathSync.native : _fs.realpathSync;
@ -1576,13 +1578,10 @@ export let sys: System = (() => {
return process.memoryUsage().heapUsed;
},
getFileSize(path) {
try {
const stat = statSync(path);
if (stat?.isFile()) {
return stat.size;
}
const stat = statSync(path);
if (stat?.isFile()) {
return stat.size;
}
catch { /*ignore*/ }
return 0;
},
exit(exitCode?: number): void {
@ -1626,14 +1625,17 @@ export let sys: System = (() => {
};
return nodeSystem;
/**
* `throwIfNoEntry` was added so recently that it's not in the node types.
* This helper encapsulates the mitigating usage of `any`.
* See https://github.com/nodejs/node/pull/33716
*/
/** Calls fs.statSync, returning undefined if any errors are thrown */
function statSync(path: string): import("fs").Stats | undefined {
// throwIfNoEntry will be ignored by older versions of node
return (_fs as any).statSync(path, { throwIfNoEntry: false });
// throwIfNoEntry is available in Node 14.17 and above, which matches our supported range.
try {
return _fs.statSync(path, statSyncOptions);
}
catch {
// This should never happen as we are passing throwIfNoEntry: false,
// but guard against this just in case (e.g. a polyfill doesn't check this flag).
return undefined;
}
}
/**
@ -1693,13 +1695,8 @@ export let sys: System = (() => {
const s = activeSession;
activeSession.post("Profiler.stop", (err, { profile }) => {
if (!err) {
try {
if (statSync(profilePath)?.isDirectory()) {
profilePath = _path.join(profilePath, `${(new Date()).toISOString().replace(/:/g, "-")}+P${process.pid}.cpuprofile`);
}
}
catch {
// do nothing and ignore fallible fs operation
if (statSync(profilePath)?.isDirectory()) {
profilePath = _path.join(profilePath, `${(new Date()).toISOString().replace(/:/g, "-")}+P${process.pid}.cpuprofile`);
}
try {
_fs.mkdirSync(_path.dirname(profilePath), { recursive: true });
@ -1857,13 +1854,8 @@ export let sys: System = (() => {
if (typeof dirent === "string" || dirent.isSymbolicLink()) {
const name = combinePaths(path, entry);
try {
stat = statSync(name);
if (!stat) {
continue;
}
}
catch {
stat = statSync(name);
if (!stat) {
continue;
}
}
@ -1892,30 +1884,17 @@ export let sys: System = (() => {
}
function fileSystemEntryExists(path: string, entryKind: FileSystemEntryKind): boolean {
// Since the error thrown by fs.statSync isn't used, we can avoid collecting a stack trace to improve
// the CPU time performance.
const originalStackTraceLimit = Error.stackTraceLimit;
Error.stackTraceLimit = 0;
try {
const stat = statSync(path);
if (!stat) {
return false;
}
switch (entryKind) {
case FileSystemEntryKind.File:
return stat.isFile();
case FileSystemEntryKind.Directory:
return stat.isDirectory();
default:
return false;
}
}
catch {
const stat = statSync(path);
if (!stat) {
return false;
}
finally {
Error.stackTraceLimit = originalStackTraceLimit;
switch (entryKind) {
case FileSystemEntryKind.File:
return stat.isFile();
case FileSystemEntryKind.Directory:
return stat.isDirectory();
default:
return false;
}
}
@ -1945,19 +1924,7 @@ export let sys: System = (() => {
}
function getModifiedTime(path: string) {
// Since the error thrown by fs.statSync isn't used, we can avoid collecting a stack trace to improve
// the CPU time performance.
const originalStackTraceLimit = Error.stackTraceLimit;
Error.stackTraceLimit = 0;
try {
return statSync(path)?.mtime;
}
catch {
return undefined;
}
finally {
Error.stackTraceLimit = originalStackTraceLimit;
}
return statSync(path)?.mtime;
}
function setModifiedTime(path: string, time: Date) {