microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix strict/es5+ octal literal 2x error #46810 (#46823)

Browse Source 
* Fix strict/es5+ octal literal 2x error #46810

Signed-off-by: Jay Clark <jay@jayeclark.dev>

* Accept baseline test changes

Signed-off-by: Jay Clark <jay@jayeclark.dev>

* Add test case

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
This commit is contained in:
Jay Clark 2021-12-06 16:46:08 -04:00 committed by GitHub
parent 2a7eb58589
commit 1fe9bfdd0e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 62 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/binder.ts
View File

@ -2335,7 +2335,7 @@ namespace ts {
}
function checkStrictModeNumericLiteral(node: NumericLiteral) {
if (inStrictMode && node.numericLiteralFlags & TokenFlags.Octal) {
if (languageVersion < ScriptTarget.ES5 && inStrictMode && node.numericLiteralFlags & TokenFlags.Octal) {
file.bindDiagnostics.push(createDiagnosticForNode(node, Diagnostics.Octal_literals_are_not_allowed_in_strict_mode));
}
}

5
tests/baselines/reference/jsFileCompilationBindStrictModeErrors.errors.txt
View File

@ -10,7 +10,6 @@ tests/cases/compiler/b.js(3,7): error TS1210: Code contained in a class is evalu
tests/cases/compiler/b.js(6,13): error TS1213: Identifier expected. 'let' is a reserved word in strict mode. Class definitions are automatically in strict mode.
tests/cases/compiler/c.js(1,12): error TS1214: Identifier expected. 'let' is a reserved word in strict mode. Modules are automatically in strict mode.
tests/cases/compiler/c.js(2,5): error TS1215: Invalid use of 'eval'. Modules are automatically in strict mode.
tests/cases/compiler/d.js(2,9): error TS1121: Octal literals are not allowed in strict mode.
tests/cases/compiler/d.js(2,11): error TS1005: ',' expected.
@ -72,10 +71,8 @@ tests/cases/compiler/d.js(2,11): error TS1005: ',' expected.
!!! error TS1215: Invalid use of 'eval'. Modules are automatically in strict mode.
};
==== tests/cases/compiler/d.js (2 errors) ====
==== tests/cases/compiler/d.js (1 errors) ====
"use strict";
var x = 009; // error
~~
!!! error TS1121: Octal literals are not allowed in strict mode.
~
!!! error TS1005: ',' expected.

5
tests/baselines/reference/plainJSBinderErrors.errors.txt
View File

@ -10,14 +10,13 @@ tests/cases/conformance/salsa/plainJSBinderErrors.js(18,16): error TS1102: 'dele
tests/cases/conformance/salsa/plainJSBinderErrors.js(19,16): error TS1102: 'delete' cannot be called on an identifier in strict mode.
tests/cases/conformance/salsa/plainJSBinderErrors.js(22,15): error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'eval'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
tests/cases/conformance/salsa/plainJSBinderErrors.js(23,15): error TS1210: Code contained in a class is evaluated in JavaScript's strict mode which does not allow this use of 'arguments'. For more information, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.
tests/cases/conformance/salsa/plainJSBinderErrors.js(26,27): error TS1121: Octal literals are not allowed in strict mode.
tests/cases/conformance/salsa/plainJSBinderErrors.js(27,9): error TS1101: 'with' statements are not allowed in strict mode.
tests/cases/conformance/salsa/plainJSBinderErrors.js(33,13): error TS1344: 'A label is not allowed here.
tests/cases/conformance/salsa/plainJSBinderErrors.js(39,7): error TS1215: Invalid use of 'eval'. Modules are automatically in strict mode.
tests/cases/conformance/salsa/plainJSBinderErrors.js(40,7): error TS1215: Invalid use of 'arguments'. Modules are automatically in strict mode.
==== tests/cases/conformance/salsa/plainJSBinderErrors.js (17 errors) ====
==== tests/cases/conformance/salsa/plainJSBinderErrors.js (16 errors) ====
export default 12
~~~~~~~~~~~~~~~~~
!!! error TS2528: A module cannot have multiple default exports.
@ -70,8 +69,6 @@ tests/cases/conformance/salsa/plainJSBinderErrors.js(40,7): error TS1215: Invali
}
withOctal() {
const redundant = 010
~~~
!!! error TS1121: Octal literals are not allowed in strict mode.
with (redundant) {
~~~~
!!! error TS1101: 'with' statements are not allowed in strict mode.

17
tests/baselines/reference/strictModeOctalLiterals.errors.txt Normal file
View File

@ -0,0 +1,17 @@
tests/cases/conformance/expressions/literals/strictModeOctalLiterals.ts(2,14): error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. Use the syntax '0o1'.
tests/cases/conformance/expressions/literals/strictModeOctalLiterals.ts(4,16): error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. Use the syntax '0o1'.
tests/cases/conformance/expressions/literals/strictModeOctalLiterals.ts(4,21): error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. Use the syntax '0o1'.
==== tests/cases/conformance/expressions/literals/strictModeOctalLiterals.ts (3 errors) ====
export enum E {
A = 12 + 01
~~
!!! error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. Use the syntax '0o1'.
}
const orbitol: 01 = 01
~~
!!! error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. Use the syntax '0o1'.
~~
!!! error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. Use the syntax '0o1'.

13
tests/baselines/reference/strictModeOctalLiterals.js Normal file
View File

@ -0,0 +1,13 @@
//// [strictModeOctalLiterals.ts]
export enum E {
A = 12 + 01
}
const orbitol: 01 = 01
//// [strictModeOctalLiterals.js]
export var E;
(function (E) {
E[E["A"] = 13] = "A";
})(E || (E = {}));
const orbitol = 01;

10
tests/baselines/reference/strictModeOctalLiterals.symbols Normal file
View File

@ -0,0 +1,10 @@
=== tests/cases/conformance/expressions/literals/strictModeOctalLiterals.ts ===
export enum E {
>E : Symbol(E, Decl(strictModeOctalLiterals.ts, 0, 0))
A = 12 + 01
>A : Symbol(E.A, Decl(strictModeOctalLiterals.ts, 0, 15))
}
const orbitol: 01 = 01
>orbitol : Symbol(orbitol, Decl(strictModeOctalLiterals.ts, 3, 5))

14
tests/baselines/reference/strictModeOctalLiterals.types Normal file
View File

@ -0,0 +1,14 @@
=== tests/cases/conformance/expressions/literals/strictModeOctalLiterals.ts ===
export enum E {
>E : E
A = 12 + 01
>A : E
>12 + 01 : number
>12 : 12
>01 : 1
}
const orbitol: 01 = 01
>orbitol : 1
>01 : 1

5
tests/cases/conformance/expressions/literals/strictModeOctalLiterals.ts Normal file
View File

@ -0,0 +1,5 @@
// @target: es2018
export enum E {
A = 12 + 01
}
const orbitol: 01 = 01