microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-26 00:36:29 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix parenthesizeForAccess to always parenthesize NewExpressions and NumberLiterals

Browse Source
This commit is contained in:
Jason Freeman
2015-04-15 17:22:19 -07:00
parent 2cadea2137
commit 1cda3dc45d
7 changed files with 54 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/compiler/emitter.ts
View File

@@ -1607,7 +1607,15 @@ var __param = this.__param || function(index, decorator) { return function (targ
}
function parenthesizeForAccess(expr: Expression): LeftHandSideExpression {
if (isLeftHandSideExpression(expr)) {
// isLeftHandSideExpression is almost the correct criterion for when it is not necessary
// to parenthesize the expression before a dot. The known exceptions are:
//
// NewExpression:
// new C.x -> not the same as (new C).x
// NumberLiteral
// 1.x -> not the same as (1).x
//
if (isLeftHandSideExpression(expr) && expr.kind !== SyntaxKind.NewExpression && expr.kind !== SyntaxKind.NumericLiteral) {
return <LeftHandSideExpression>expr;
}
let node = <ParenthesizedExpression>createSynthesizedNode(SyntaxKind.ParenthesizedExpression);