microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 21:36:50 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Optimize module resolution cache for watch and editor (#37055)

Browse Source 
* Refactor resolveName

* Have resolutions of failed lookups as array and resolved to fileName map
This commit is contained in:
Sheetal Nandi
2020-03-11 14:35:26 -07:00
committed by GitHub
parent 6856c012d2
commit 1a9c8197ff
12 changed files with 152 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/executeCommandLine/executeCommandLine.ts
View File

@@ -156,7 +156,6 @@ namespace ts {
sys: System,
cb: ExecuteCommandLineCallbacks,
commandLine: ParsedCommandLine,
maxNumberOfFilesToIterateForInvalidation: number | undefined
) {
let reportDiagnostic = createDiagnosticReporter(sys);
if (commandLine.options.build) {
@@ -271,7 +270,6 @@ namespace ts {
configParseResult,
commandLineOptions,
commandLine.watchOptions,
maxNumberOfFilesToIterateForInvalidation
);
}
else if (isIncrementalCompilation(configParseResult.options)) {
@@ -311,7 +309,6 @@ namespace ts {
commandLine.fileNames,
commandLineOptions,
commandLine.watchOptions,
maxNumberOfFilesToIterateForInvalidation
);
}
else if (isIncrementalCompilation(commandLineOptions)) {
@@ -346,7 +343,6 @@ namespace ts {
system: System,
cb: ExecuteCommandLineCallbacks,
commandLineArgs: readonly string[],
maxNumberOfFilesToIterateForInvalidation?: number
) {
if (isBuild(commandLineArgs)) {
const { buildOptions, watchOptions, projects, errors } = parseBuildCommand(commandLineArgs.slice(1));
@@ -378,11 +374,10 @@ namespace ts {
system,
cb,
commandLine,
maxNumberOfFilesToIterateForInvalidation
));
}
else {
return executeCommandLineWorker(system, cb, commandLine, maxNumberOfFilesToIterateForInvalidation);
return executeCommandLineWorker(system, cb, commandLine);
}
}
@@ -556,10 +551,8 @@ namespace ts {
sys: System,
cb: ExecuteCommandLineCallbacks,
watchCompilerHost: WatchCompilerHost<EmitAndSemanticDiagnosticsBuilderProgram>,
maxNumberOfFilesToIterateForInvalidation: number | undefined
) {
updateCreateProgram(sys, watchCompilerHost);
watchCompilerHost.maxNumberOfFilesToIterateForInvalidation = maxNumberOfFilesToIterateForInvalidation;
const emitFilesUsingBuilder = watchCompilerHost.afterProgramCreate!; // TODO: GH#18217
watchCompilerHost.afterProgramCreate = builderProgram => {
emitFilesUsingBuilder(builderProgram);
@@ -579,7 +572,6 @@ namespace ts {
configParseResult: ParsedCommandLine,
optionsToExtend: CompilerOptions,
watchOptionsToExtend: WatchOptions | undefined,
maxNumberOfFilesToIterateForInvalidation: number | undefined
) {
const watchCompilerHost = createWatchCompilerHostOfConfigFile(
configParseResult.options.configFilePath!,
@@ -590,7 +582,7 @@ namespace ts {
reportDiagnostic,
createWatchStatusReporter(sys, configParseResult.options)
); // TODO: GH#18217
updateWatchCompilationHost(sys, cb, watchCompilerHost, maxNumberOfFilesToIterateForInvalidation);
updateWatchCompilationHost(sys, cb, watchCompilerHost);
watchCompilerHost.configFileParsingResult = configParseResult;
return createWatchProgram(watchCompilerHost);
}
@@ -602,7 +594,6 @@ namespace ts {
rootFiles: string[],
options: CompilerOptions,
watchOptions: WatchOptions | undefined,
maxNumberOfFilesToIterateForInvalidation: number | undefined
) {
const watchCompilerHost = createWatchCompilerHostOfFilesAndCompilerOptions(
rootFiles,
@@ -613,7 +604,7 @@ namespace ts {
reportDiagnostic,
createWatchStatusReporter(sys, options)
);
updateWatchCompilationHost(sys, cb, watchCompilerHost, maxNumberOfFilesToIterateForInvalidation);
updateWatchCompilationHost(sys, cb, watchCompilerHost);
return createWatchProgram(watchCompilerHost);
}