From 8a2d16134d0001d5c0ce8f1b1df451f4a93af982 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Mon, 17 Oct 2016 06:09:19 -0700 Subject: [PATCH 1/2] Remove unnecessary assert --- src/server/scriptInfo.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/server/scriptInfo.ts b/src/server/scriptInfo.ts index 68dd59d2d32..2792b3e47a9 100644 --- a/src/server/scriptInfo.ts +++ b/src/server/scriptInfo.ts @@ -84,11 +84,7 @@ namespace ts.server { } getDefaultProject() { - if (this.containingProjects.length === 0) { - return Errors.ThrowNoProject(); - } - Debug.assert(this.containingProjects.length !== 0); - return this.containingProjects[0]; + return this.containingProjects.length === 0 ? Errors.ThrowNoProject() : this.containingProjects[0]; } setFormatOptions(formatSettings: FormatCodeSettings): void { From 4c5a72831466c2738c81dfe3fa5634c11ae093a0 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Mon, 17 Oct 2016 10:15:13 -0700 Subject: [PATCH 2/2] Don't use ternary operator --- src/server/scriptInfo.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/server/scriptInfo.ts b/src/server/scriptInfo.ts index 2792b3e47a9..78127925958 100644 --- a/src/server/scriptInfo.ts +++ b/src/server/scriptInfo.ts @@ -84,7 +84,10 @@ namespace ts.server { } getDefaultProject() { - return this.containingProjects.length === 0 ? Errors.ThrowNoProject() : this.containingProjects[0]; + if (this.containingProjects.length === 0) { + return Errors.ThrowNoProject(); + } + return this.containingProjects[0]; } setFormatOptions(formatSettings: FormatCodeSettings): void {