Disable checkJS survey (#29830)

* Disable checkJS survey

* Completely remove survey infrastructure

* Re-instate the protocol part of SurveyReady

src/server/editorServices.ts

@@ -7,7 +7,6 @@ namespace ts.server {
     export const ProjectsUpdatedInBackgroundEvent = "projectsUpdatedInBackground";
     export const ProjectLoadingStartEvent = "projectLoadingStart";
     export const ProjectLoadingFinishEvent = "projectLoadingFinish";
-    export const SurveyReady = "surveyReady";
     export const LargeFileReferencedEvent = "largeFileReferenced";
     export const ConfigFileDiagEvent = "configFileDiag";
     export const ProjectLanguageServiceStateEvent = "projectLanguageServiceState";
@@ -30,11 +29,6 @@ namespace ts.server {
         data: { project: Project; };
     }
 
-    export interface SurveyReady {
-        eventName: typeof SurveyReady;
-        data: { surveyId: string; };
-    }
-
     export interface LargeFileReferencedEvent {
         eventName: typeof LargeFileReferencedEvent;
         data: { file: string; fileSize: number; maxFileSize: number; };
@@ -146,7 +140,6 @@ namespace ts.server {
     }
 
     export type ProjectServiceEvent = LargeFileReferencedEvent |
-        SurveyReady |
         ProjectsUpdatedInBackgroundEvent |
         ProjectLoadingStartEvent |
         ProjectLoadingFinishEvent |
@@ -518,9 +511,6 @@ namespace ts.server {
         /** Tracks projects that we have already sent telemetry for. */
         private readonly seenProjects = createMap<true>();
 
-        /** Tracks projects that we have already sent survey events for. */
-        private readonly seenSurveyProjects = createMap<true>();
-
         /*@internal*/
         readonly watchFactory: WatchFactory<WatchType, Project>;
 
@@ -722,14 +712,6 @@ namespace ts.server {
             this.eventHandler(event);
         }
 
-        /* @internal */
-        sendSurveyReadyEvent(surveyId: string) {
-            if (!this.eventHandler) {
-                return;
-            }
-            this.eventHandler({ eventName: SurveyReady, data: { surveyId } });
-        }
-
         /* @internal */
         sendLargeFileReferencedEvent(file: string, fileSize: number) {
             if (!this.eventHandler) {
@@ -1611,20 +1593,6 @@ namespace ts.server {
             return project;
         }
 
-        /*@internal*/
-        sendSurveyReady(project: ExternalProject | ConfiguredProject): void {
-            if (this.seenSurveyProjects.has(project.projectName)) {
-                return;
-            }
-
-            if (project.getCompilerOptions().checkJs !== undefined) {
-                const name = "checkJs";
-                this.logger.info(`Survey ${name} is ready`);
-                this.sendSurveyReadyEvent(name);
-                this.seenSurveyProjects.set(project.projectName, true);
-            }
-        }
-
         /*@internal*/
         sendProjectTelemetry(project: ExternalProject | ConfiguredProject): void {
             if (this.seenProjects.has(project.projectName)) {

src/server/project.ts

@@ -1431,7 +1431,6 @@ namespace ts.server {
             }
             this.projectService.sendProjectLoadingFinishEvent(this);
             this.projectService.sendProjectTelemetry(this);
-            this.projectService.sendSurveyReady(this);
             return result;
         }
 
@@ -1627,7 +1626,6 @@ namespace ts.server {
         updateGraph() {
             const result = super.updateGraph();
             this.projectService.sendProjectTelemetry(this);
-            this.projectService.sendSurveyReady(this);
             return result;
         }
 

src/server/session.ts

@@ -610,10 +610,6 @@ namespace ts.server {
                         diagnostics: bakedDiags
                     }, ConfigFileDiagEvent);
                     break;
-                case SurveyReady:
-                    const { surveyId } = event.data;
-                    this.event<protocol.SurveyReadyEventBody>({ surveyId }, SurveyReady);
-                    break;
                 case ProjectLanguageServiceStateEvent: {
                     const eventName: protocol.ProjectLanguageServiceStateEventName = ProjectLanguageServiceStateEvent;
                     this.event<protocol.ProjectLanguageServiceStateEventBody>({

src/testRunner/tsconfig.json

@@ -109,7 +109,6 @@
         "unittests/tsserver/events/projectLanguageServiceState.ts",
         "unittests/tsserver/events/projectLoading.ts",
         "unittests/tsserver/events/projectUpdatedInBackground.ts",
-        "unittests/tsserver/events/surveyReady.ts",
         "unittests/tsserver/externalProjects.ts",
         "unittests/tsserver/forceConsistentCasingInFileNames.ts",
         "unittests/tsserver/formatSettings.ts",

src/testRunner/unittests/tsserver/events/surveyReady.ts

@@ -1,111 +0,0 @@
-namespace ts.projectSystem {
-    describe("unittests:: tsserver:: events:: SurveyReady", () => {
-        function createSessionWithEventHandler(host: TestServerHost) {
-            const { session, events: surveyEvents } = createSessionWithEventTracking<server.SurveyReady>(host, server.SurveyReady);
-
-            return { session, verifySurveyReadyEvent };
-
-            function verifySurveyReadyEvent(numberOfEvents: number) {
-                assert.equal(surveyEvents.length, numberOfEvents);
-                const expectedEvents = numberOfEvents === 0 ? [] : [{
-                    eventName: server.SurveyReady,
-                    data: { surveyId: "checkJs" }
-                }];
-                assert.deepEqual(surveyEvents, expectedEvents);
-            }
-        }
-
-        it("doesn't log an event when checkJs isn't set", () => {
-            const projectRoot = "/user/username/projects/project";
-            const file: File = {
-                path: `${projectRoot}/src/file.ts`,
-                content: "export var y = 10;"
-            };
-            const tsconfig: File = {
-                path: `${projectRoot}/tsconfig.json`,
-                content: JSON.stringify({ compilerOptions: {} }),
-            };
-            const host = createServerHost([file, tsconfig]);
-            const { session, verifySurveyReadyEvent } = createSessionWithEventHandler(host);
-            const service = session.getProjectService();
-            openFilesForSession([file], session);
-            checkNumberOfProjects(service, { configuredProjects: 1 });
-            const project = service.configuredProjects.get(tsconfig.path)!;
-            checkProjectActualFiles(project, [file.path, tsconfig.path]);
-
-            verifySurveyReadyEvent(0);
-        });
-
-        it("logs an event when checkJs is set", () => {
-            const projectRoot = "/user/username/projects/project";
-            const file: File = {
-                path: `${projectRoot}/src/file.ts`,
-                content: "export var y = 10;"
-            };
-            const tsconfig: File = {
-                path: `${projectRoot}/tsconfig.json`,
-                content: JSON.stringify({ compilerOptions: { checkJs: true } }),
-            };
-            const host = createServerHost([file, tsconfig]);
-            const { session, verifySurveyReadyEvent } = createSessionWithEventHandler(host);
-            openFilesForSession([file], session);
-
-            verifySurveyReadyEvent(1);
-        });
-
-        it("logs an event when checkJs is set, only the first time", () => {
-            const projectRoot = "/user/username/projects/project";
-            const file: File = {
-                path: `${projectRoot}/src/file.ts`,
-                content: "export var y = 10;"
-            };
-            const rando: File = {
-                path: `/rando/calrissian.ts`,
-                content: "export function f() { }"
-            };
-            const tsconfig: File = {
-                path: `${projectRoot}/tsconfig.json`,
-                content: JSON.stringify({ compilerOptions: { checkJs: true } }),
-            };
-            const host = createServerHost([file, tsconfig]);
-            const { session, verifySurveyReadyEvent } = createSessionWithEventHandler(host);
-            openFilesForSession([file], session);
-
-            verifySurveyReadyEvent(1);
-
-            closeFilesForSession([file], session);
-            openFilesForSession([rando], session);
-            openFilesForSession([file], session);
-
-            verifySurveyReadyEvent(1);
-        });
-
-        it("logs an event when checkJs is set after closing and reopening", () => {
-            const projectRoot = "/user/username/projects/project";
-            const file: File = {
-                path: `${projectRoot}/src/file.ts`,
-                content: "export var y = 10;"
-            };
-            const rando: File = {
-                path: `/rando/calrissian.ts`,
-                content: "export function f() { }"
-            };
-            const tsconfig: File = {
-                path: `${projectRoot}/tsconfig.json`,
-                content: JSON.stringify({}),
-            };
-            const host = createServerHost([file, tsconfig]);
-            const { session, verifySurveyReadyEvent } = createSessionWithEventHandler(host);
-            openFilesForSession([file], session);
-
-            verifySurveyReadyEvent(0);
-
-            closeFilesForSession([file], session);
-            openFilesForSession([rando], session);
-            host.writeFile(tsconfig.path, JSON.stringify({ compilerOptions: { checkJs: true } }));
-            openFilesForSession([file], session);
-
-            verifySurveyReadyEvent(1);
-        });
-    });
-}