From 0a83d797ddb47253b5e6a5e597ff66499dd9b78a Mon Sep 17 00:00:00 2001 From: Jason Ramsay Date: Tue, 27 Sep 2016 13:22:48 -0700 Subject: [PATCH] Issue: Commit on enter isn't working correctly for JS completions in VS Fix: revert the change to always return true for isNewIdentifierLocation for JavaScript files. With recent Roslyn completion list changes and the new VS default statement completion settings to "Only use Tab or Enter to commit" this change is no longer required. There is no longer a completion on space issue for JavaScript in VS and the previous fix is stopping completion on enter from working correctly. --- src/services/completions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/completions.ts b/src/services/completions.ts index d6a4da89ed1..a43717921c4 100644 --- a/src/services/completions.ts +++ b/src/services/completions.ts @@ -56,7 +56,7 @@ namespace ts.Completions { addRange(entries, keywordCompletions); } - return { isMemberCompletion, isNewIdentifierLocation: isNewIdentifierLocation || isSourceFileJavaScript(sourceFile), entries }; + return { isMemberCompletion, isNewIdentifierLocation: isNewIdentifierLocation, entries }; function getJavaScriptCompletionEntries(sourceFile: SourceFile, position: number, uniqueNames: Map): CompletionEntry[] { const entries: CompletionEntry[] = [];