From 2ea3123dbd4b58e811032718ec1d501a823c7f22 Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Fri, 27 Jul 2018 15:56:26 +0200 Subject: [PATCH] allow BindingPattern in BindingRestElement Part of #6275 --- src/compiler/checker.ts | 4 ---- .../reference/restElementWithBindingPattern.errors.txt | 7 ------- .../reference/restElementWithBindingPattern2.errors.txt | 5 +---- 3 files changed, 1 insertion(+), 15 deletions(-) delete mode 100644 tests/baselines/reference/restElementWithBindingPattern.errors.txt diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 2b255da7ae3..759ea4d3801 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -29188,10 +29188,6 @@ namespace ts { } checkGrammarForDisallowedTrailingComma(elements, Diagnostics.A_rest_parameter_or_binding_pattern_may_not_have_a_trailing_comma); - if (node.name.kind === SyntaxKind.ArrayBindingPattern || node.name.kind === SyntaxKind.ObjectBindingPattern) { - return grammarErrorOnNode(node.name, Diagnostics.A_rest_element_cannot_contain_a_binding_pattern); - } - if (node.propertyName) { return grammarErrorOnNode(node.name, Diagnostics.A_rest_element_cannot_have_a_property_name); } diff --git a/tests/baselines/reference/restElementWithBindingPattern.errors.txt b/tests/baselines/reference/restElementWithBindingPattern.errors.txt deleted file mode 100644 index 671b722db73..00000000000 --- a/tests/baselines/reference/restElementWithBindingPattern.errors.txt +++ /dev/null @@ -1,7 +0,0 @@ -tests/cases/conformance/es6/destructuring/restElementWithBindingPattern.ts(1,9): error TS2501: A rest element cannot contain a binding pattern. - - -==== tests/cases/conformance/es6/destructuring/restElementWithBindingPattern.ts (1 errors) ==== - var [...[a, b]] = [0, 1]; - ~~~~~~ -!!! error TS2501: A rest element cannot contain a binding pattern. \ No newline at end of file diff --git a/tests/baselines/reference/restElementWithBindingPattern2.errors.txt b/tests/baselines/reference/restElementWithBindingPattern2.errors.txt index 9645a028a4e..8e744ac54a3 100644 --- a/tests/baselines/reference/restElementWithBindingPattern2.errors.txt +++ b/tests/baselines/reference/restElementWithBindingPattern2.errors.txt @@ -1,10 +1,7 @@ -tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts(1,9): error TS2501: A rest element cannot contain a binding pattern. tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts(1,16): error TS2459: Type 'number[]' has no property 'b' and no string index signature. -==== tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts (2 errors) ==== +==== tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts (1 errors) ==== var [...{0: a, b }] = [0, 1]; - ~~~~~~~~~~ -!!! error TS2501: A rest element cannot contain a binding pattern. ~ !!! error TS2459: Type 'number[]' has no property 'b' and no string index signature. \ No newline at end of file