microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 21:36:50 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Address CR feedback

Browse Source
This commit is contained in:
Anders Hejlsberg
2018-12-17 15:06:15 -08:00
parent 519e19ae03
commit 109fcd5d43
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/compiler/checker.ts
View File

@@ -14633,7 +14633,7 @@ namespace ts {
case SyntaxKind.PropertyAccessExpression:
case SyntaxKind.ElementAccessExpression:
const propName = getAccessedPropertyName(<AccessExpression>node);
if (propName) {
if (propName !== undefined) {
const key = getFlowCacheKey((<AccessExpression>node).expression);
return key && key + "." + propName;
}
@@ -14694,7 +14694,7 @@ namespace ts {
const type = getDeclaredTypeOfReference(expr.expression);
if (type) {
const propName = getAccessedPropertyName(expr);
return propName && getTypeOfPropertyOfType(type, propName);
return propName !== undefined ? getTypeOfPropertyOfType(type, propName) : undefined;
}
}
return undefined;
@@ -15645,7 +15645,7 @@ namespace ts {
return false;
}
const name = getAccessedPropertyName(expr);
if (!name) {
if (name === undefined) {
return false;
}
return isMatchingReference(reference, expr.expression) && isDiscriminantProperty(computedType, name);
@@ -15653,7 +15653,7 @@ namespace ts {
function narrowTypeByDiscriminant(type: Type, access: AccessExpression, narrowType: (t: Type) => Type): Type {
const propName = getAccessedPropertyName(access);
if (!propName) {
if (propName === undefined) {
return type;
}
const propType = getTypeOfPropertyOfType(type, propName);