From 0b8b90cdbc7f2e7a504b14bbe8d74bd92065c333 Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Sun, 30 Nov 2014 22:41:20 -0800 Subject: [PATCH] Code review feedback. Explain how TypeLiterals and ObjectLiterals are declarations. Rename variable to be clearer. --- src/compiler/checker.ts | 8 ++++---- src/compiler/types.ts | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 738c684f554..c43d1074dfa 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -1575,12 +1575,12 @@ module ts { } // Container of resolvedExportSymbol is visible - return forEach(resolvedExportSymbol.declarations, (declaration: Node) => { - while (declaration) { - if (declaration === node) { + return forEach(resolvedExportSymbol.declarations, (current: Node) => { + while (current) { + if (current === node) { return true; } - declaration = declaration.parent; + current = current.parent; } }); } diff --git a/src/compiler/types.ts b/src/compiler/types.ts index 81b96ed3072..e97aaeb2edb 100644 --- a/src/compiler/types.ts +++ b/src/compiler/types.ts @@ -421,6 +421,7 @@ module ts { exprName: EntityName; } + // A TypeLiteral is the declaration node for an anonymous symbol. export interface TypeLiteralNode extends TypeNode, Declaration { members: NodeArray; } @@ -547,7 +548,8 @@ module ts { export interface ArrayLiteralExpression extends PrimaryExpression { elements: NodeArray; } - + + // An ObjectLiteralExpression is the declaration node for an anonymous symbol. export interface ObjectLiteralExpression extends PrimaryExpression, Declaration { properties: NodeArray; }