microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 16:38:05 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Code review feedback

Browse Source
This commit is contained in:
Sheetal Nandi 2014-11-12 18:42:31 -08:00
parent 5e94f4a5c2
commit 0877a650c3
7 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/navigationBar.ts
View File

@ -236,9 +236,9 @@ module ts.NavigationBar {
case SyntaxKind.VariableDeclaration:
if (isConst(node)) {
return createItem(node, getTextOfNode((<VariableDeclaration>node).name), ts.ScriptElementKind.constantElement);
return createItem(node, getTextOfNode((<VariableDeclaration>node).name), ts.ScriptElementKind.constElement);
}
else if (node.flags & NodeFlags.Let) {
else if (isLet(node)) {
return createItem(node, getTextOfNode((<VariableDeclaration>node).name), ts.ScriptElementKind.letElement);
}
else {

10
src/services/services.ts
View File

@ -1224,7 +1224,7 @@ module ts {
static alias = "alias";
static constantElement = "constant";
static constElement = "const";
static letElement = "let";
}
@ -2860,9 +2860,9 @@ module ts {
return ScriptElementKind.parameterElement;
}
else if (symbol.valueDeclaration && isConst(symbol.valueDeclaration)) {
return ScriptElementKind.constantElement;
return ScriptElementKind.constElement;
}
else if (forEach(symbol.declarations, declaration => declaration.flags & NodeFlags.Let)) {
else if (forEach(symbol.declarations, declaration => isLet(declaration))) {
return ScriptElementKind.letElement;
}
return isLocalVariableOrFunction(symbol) ? ScriptElementKind.localVariableElement : ScriptElementKind.variableElement;
@ -2921,7 +2921,7 @@ module ts {
case SyntaxKind.TypeAliasDeclaration: return ScriptElementKind.typeElement;
case SyntaxKind.EnumDeclaration: return ScriptElementKind.enumElement;
case SyntaxKind.VariableDeclaration: return isConst(node)
? ScriptElementKind.constantElement
? ScriptElementKind.constElement
: node.flags & NodeFlags.Let
? ScriptElementKind.letElement
: ScriptElementKind.variableElement;
@ -3023,7 +3023,7 @@ module ts {
switch (symbolKind) {
case ScriptElementKind.memberVariableElement:
case ScriptElementKind.variableElement:
case ScriptElementKind.constantElement:
case ScriptElementKind.constElement:
case ScriptElementKind.parameterElement:
case ScriptElementKind.localVariableElement:
// If it is call or construct signature of lambda's write type name

2
tests/cases/fourslash/completionEntryForConst.ts
View File

@ -4,4 +4,4 @@
/////**/
goTo.marker();
verify.completionListContains("c", /*text*/ undefined, /*documentation*/ undefined, "constant");
verify.completionListContains("c", "(const) c: string", /*documentation*/ undefined, "const");

26
tests/cases/fourslash/constQuickInfoAndCompletionList.ts
View File

@ -10,28 +10,28 @@
//// /*7*/
////}
goTo.marker('1');
verify.quickInfoIs("(constant) a: number");
verify.quickInfoIs("(const) a: number");
goTo.marker('2');
verify.completionListContains("a", "(constant) a: number");
verify.quickInfoIs("(constant) a: number");
verify.completionListContains("a", "(const) a: number");
verify.quickInfoIs("(const) a: number");
goTo.marker('3');
verify.completionListContains("a", "(constant) a: number");
verify.completionListContains("a", "(const) a: number");
goTo.marker('4');
verify.quickInfoIs("(constant) b: number");
verify.quickInfoIs("(const) b: number");
goTo.marker('5');
verify.completionListContains("a", "(constant) a: number");
verify.completionListContains("b", "(constant) b: number");
verify.quickInfoIs("(constant) b: number");
verify.completionListContains("a", "(const) a: number");
verify.completionListContains("b", "(const) b: number");
verify.quickInfoIs("(const) b: number");
goTo.marker('6');
verify.completionListContains("a", "(constant) a: number");
verify.completionListContains("b", "(constant) b: number");
verify.quickInfoIs("(constant) a: number");
verify.completionListContains("a", "(const) a: number");
verify.completionListContains("b", "(const) b: number");
verify.quickInfoIs("(const) a: number");
goTo.marker('7');
verify.completionListContains("a", "(constant) a: number");
verify.completionListContains("b", "(constant) b: number");
verify.completionListContains("a", "(const) a: number");
verify.completionListContains("b", "(const) b: number");

2
tests/cases/fourslash/navbar_const.ts
View File

@ -1,6 +1,6 @@
/// <reference path="fourslash.ts" />
//// {| "itemName": "c", "kind": "constant", "parentName": "" |}const c = 0;
//// {| "itemName": "c", "kind": "const", "parentName": "" |}const c = 0;
test.markers().forEach(marker => {
verify.getScriptLexicalStructureListContains(

4
tests/cases/fourslash/navigateItemsConst.ts
View File

@ -1,8 +1,8 @@
/// <reference path="fourslash.ts" />
////{| "itemName": "c", "kind": "constant", "parentName": "" |}const c = 10;
////{| "itemName": "c", "kind": "const", "parentName": "" |}const c = 10;
////function foo() {
//// {| "itemName": "d", "kind": "constant", "parentName": "foo" |}const d = 10;
//// {| "itemName": "d", "kind": "const", "parentName": "foo" |}const d = 10;
////}
test.markers().forEach(marker => {

2
tests/cases/fourslash/quickInfoForConstDeclaration.ts
View File

@ -3,4 +3,4 @@
////const /**/c = 0 ;
goTo.marker();
verify.quickInfoIs("(constant) c: number");
verify.quickInfoIs("(const) c: number");