microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-17 21:09:09 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Infer void from expr statement usage, not calls

Browse Source 
This makes inferences a lot better.
This commit is contained in:
Nathan Shively-Sanders
2019-09-05 16:16:35 -07:00
parent ff38a1bc9b
commit 052a3d9d73
7 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/services/codefixes/inferFromUsage.ts
View File

@@ -504,6 +504,9 @@ namespace ts.codefix {
}
switch (node.parent.kind) {
case SyntaxKind.ExpressionStatement:
addCandidateType(usage, checker.getVoidType());
break;
case SyntaxKind.PostfixUnaryExpression:
usage.isNumber = true;
break;
@@ -871,12 +874,11 @@ namespace ts.codefix {
}
if (usage.calls) {
callSignatures.push(getSignatureFromCalls(usage.calls, checker.getVoidType()));
callSignatures.push(getSignatureFromCalls(usage.calls, checker.getAnyType()));
}
if (usage.constructs) {
// TODO: fallback return should maybe be {}?
constructSignatures.push(getSignatureFromCalls(usage.constructs, checker.getVoidType()));
constructSignatures.push(getSignatureFromCalls(usage.constructs, checker.getAnyType()));
}
if (usage.stringIndex) {