From 03fd77657d06398cd55f56c6622ae8584d8a3497 Mon Sep 17 00:00:00 2001
From: Stanislav Iliev <gigobest2@gmail.com>
Date: Wed, 10 Jan 2018 03:11:57 +0200
Subject: [PATCH] Issue implicit any errors for mapped types without
 annotations (#21104)

* Fixed #21011

* Updated code of merged message

* Reversed message code change and moved error to it's appropriate position

* Applied suggested improvements

* Fixed wrong diagnostics message in checker

* Reverted diagnostic message change
---
 src/compiler/checker.ts                                  | 8 ++++++++
 src/compiler/diagnosticMessages.json                     | 5 ++++-
 tests/baselines/reference/anyMappedTypesError.errors.txt | 7 +++++++
 tests/baselines/reference/anyMappedTypesError.js         | 4 ++++
 tests/baselines/reference/anyMappedTypesError.symbols    | 5 +++++
 tests/baselines/reference/anyMappedTypesError.types      | 5 +++++
 tests/cases/compiler/anyMappedTypesError.ts              | 3 +++
 7 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 tests/baselines/reference/anyMappedTypesError.errors.txt
 create mode 100644 tests/baselines/reference/anyMappedTypesError.js
 create mode 100644 tests/baselines/reference/anyMappedTypesError.symbols
 create mode 100644 tests/baselines/reference/anyMappedTypesError.types
 create mode 100644 tests/cases/compiler/anyMappedTypesError.ts

diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
index 16bfd7fa7e2..540f3722f92 100644
--- a/src/compiler/checker.ts
+++ b/src/compiler/checker.ts
@@ -11281,6 +11281,9 @@ namespace ts {
                     }
                     diagnostic = Diagnostics._0_which_lacks_return_type_annotation_implicitly_has_an_1_return_type;
                     break;
+                case SyntaxKind.MappedType:
+                    error(declaration, Diagnostics.Mapped_object_type_implicitly_has_an_any_template_type);
+                    return;
                 default:
                     diagnostic = Diagnostics.Variable_0_implicitly_has_an_1_type;
             }
@@ -20312,6 +20315,11 @@ namespace ts {
         function checkMappedType(node: MappedTypeNode) {
             checkSourceElement(node.typeParameter);
             checkSourceElement(node.type);
+
+            if (noImplicitAny && !node.type) {
+                reportImplicitAnyError(node, anyType);
+            }
+
             const type = <MappedType>getTypeFromMappedTypeNode(node);
             const constraintType = getConstraintTypeFromMappedType(type);
             checkTypeAssignableTo(constraintType, stringType, node.typeParameter.constraint);
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
index 96be3e99fdc..4c091673137 100644
--- a/src/compiler/diagnosticMessages.json
+++ b/src/compiler/diagnosticMessages.json
@@ -3571,7 +3571,10 @@
         "category": "Error",
         "code": 7038
     },
-
+    "Mapped object type implicitly has an 'any' template type.": {
+        "category": "Error",
+        "code": 7039
+    },
     "You cannot rename this element.": {
         "category": "Error",
         "code": 8000
diff --git a/tests/baselines/reference/anyMappedTypesError.errors.txt b/tests/baselines/reference/anyMappedTypesError.errors.txt
new file mode 100644
index 00000000000..e1442c15723
--- /dev/null
+++ b/tests/baselines/reference/anyMappedTypesError.errors.txt
@@ -0,0 +1,7 @@
+tests/cases/compiler/anyMappedTypesError.ts(1,12): error TS7039: Mapped object type implicitly has an 'any' template type.
+
+
+==== tests/cases/compiler/anyMappedTypesError.ts (1 errors) ====
+    type Foo = {[P in "bar"]};
+               ~~~~~~~~~~~~~~
+!!! error TS7039: Mapped object type implicitly has an 'any' template type.
\ No newline at end of file
diff --git a/tests/baselines/reference/anyMappedTypesError.js b/tests/baselines/reference/anyMappedTypesError.js
new file mode 100644
index 00000000000..8797d2cfc0e
--- /dev/null
+++ b/tests/baselines/reference/anyMappedTypesError.js
@@ -0,0 +1,4 @@
+//// [anyMappedTypesError.ts]
+type Foo = {[P in "bar"]};
+
+//// [anyMappedTypesError.js]
diff --git a/tests/baselines/reference/anyMappedTypesError.symbols b/tests/baselines/reference/anyMappedTypesError.symbols
new file mode 100644
index 00000000000..0e9a425aad3
--- /dev/null
+++ b/tests/baselines/reference/anyMappedTypesError.symbols
@@ -0,0 +1,5 @@
+=== tests/cases/compiler/anyMappedTypesError.ts ===
+type Foo = {[P in "bar"]};
+>Foo : Symbol(Foo, Decl(anyMappedTypesError.ts, 0, 0))
+>P : Symbol(P, Decl(anyMappedTypesError.ts, 0, 13))
+
diff --git a/tests/baselines/reference/anyMappedTypesError.types b/tests/baselines/reference/anyMappedTypesError.types
new file mode 100644
index 00000000000..290ea6883b1
--- /dev/null
+++ b/tests/baselines/reference/anyMappedTypesError.types
@@ -0,0 +1,5 @@
+=== tests/cases/compiler/anyMappedTypesError.ts ===
+type Foo = {[P in "bar"]};
+>Foo : Foo
+>P : P
+
diff --git a/tests/cases/compiler/anyMappedTypesError.ts b/tests/cases/compiler/anyMappedTypesError.ts
new file mode 100644
index 00000000000..6b37b286046
--- /dev/null
+++ b/tests/cases/compiler/anyMappedTypesError.ts
@@ -0,0 +1,3 @@
+// @noImplicitAny: true
+
+type Foo = {[P in "bar"]};
\ No newline at end of file