microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-12-12 11:50:54 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Allow trailing commas on lambda type parameter lists (#59612)

Browse Source
This commit is contained in:
Wesley Wigham 2024-08-13 11:55:27 -07:00 committed by GitHub
parent 562b815ba3
commit 03bca1d8fe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/emitter.ts
View File

@ -4508,7 +4508,7 @@ export function createPrinter(printerOptions: PrinterOptions = {}, handlers: Pri
if (isFunctionLike(parentNode) && parentNode.typeArguments) { // Quick info uses type arguments in place of type parameters on instantiated signatures
return emitTypeArguments(parentNode, parentNode.typeArguments);
}
emitList(parentNode, typeParameters, ListFormat.TypeParameters);
emitList(parentNode, typeParameters, ListFormat.TypeParameters | (isArrowFunction(parentNode) ? ListFormat.AllowTrailingComma : ListFormat.None));
}
function emitParameters(parentNode: Node, parameters: NodeArray<ParameterDeclaration>) {

11
src/testRunner/unittests/printer.ts
View File

@ -100,6 +100,17 @@ describe("unittests:: PrinterAPI", () => {
ts.ScriptKind.TSX,
));
});
// https://github.com/microsoft/TypeScript/issues/59587
printsCorrectly("lambda type parameter lists in tsx", {}, printer => {
return printer.printFile(ts.createSourceFile(
"source.tsx",
String.raw`export const id = <T,>(id: T): T => id`,
ts.ScriptTarget.ESNext,
/*setParentNodes*/ undefined,
ts.ScriptKind.TSX,
));
});
});
describe("No duplicate ref directives when emiting .d.ts->.d.ts", () => {

1
tests/baselines/reference/printerApi/printsFileCorrectly.lambda type parameter lists in tsx.js Normal file
View File

@ -0,0 +1 @@
export const id = <T,>(id: T): T => id;