microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-11 20:37:46 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Add a simple queue implementation with better performance than Array.shift (#49623)

Browse Source 
* Add a simple queue implementation with better performance than `Array.shift`

This lets us clean up the hack introduced in #49581

* Correct typo

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
This commit is contained in:
Andrew Casey
2022-06-24 10:07:28 -07:00
committed by GitHub
parent b24b6a1125
commit 020ef41543
7 changed files with 81 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/tsserver/nodeServer.ts
View File

@@ -194,7 +194,7 @@ namespace ts.server {
}
};
const pending: Buffer[] = [];
const pending = createQueue<Buffer>();
let canWrite = true;
if (useWatchGuard) {
@@ -334,7 +334,7 @@ namespace ts.server {
function writeMessage(buf: Buffer) {
if (!canWrite) {
pending.push(buf);
pending.enqueue(buf);
}
else {
canWrite = false;
@@ -344,8 +344,8 @@ namespace ts.server {
function setCanWriteFlagAndWriteMessageIfNecessary() {
canWrite = true;
if (pending.length) {
writeMessage(pending.shift()!);
if (!pending.isEmpty()) {
writeMessage(pending.dequeue());
}
}
@@ -430,7 +430,7 @@ namespace ts.server {
private installer!: NodeChildProcess;
private projectService!: ProjectService;
private activeRequestCount = 0;
private requestQueue: QueuedOperation[] = [];
private requestQueue = createQueue<QueuedOperation>();
private requestMap = new Map<string, QueuedOperation>(); // Maps operation ID to newest requestQueue entry with that ID
/** We will lazily request the types registry on the first call to `isKnownTypesPackageName` and store it in `typesRegistryCache`. */
private requestedRegistry = false;
@@ -567,7 +567,7 @@ namespace ts.server {
if (this.logger.hasLevel(LogLevel.verbose)) {
this.logger.info(`Deferring request for: ${operationId}`);
}
this.requestQueue.push(queuedRequest);
this.requestQueue.enqueue(queuedRequest);
this.requestMap.set(operationId, queuedRequest);
}
}
@@ -649,8 +649,8 @@ namespace ts.server {
Debug.fail("Received too many responses");
}
while (this.requestQueue.length > 0) {
const queuedRequest = this.requestQueue.shift()!;
while (!this.requestQueue.isEmpty()) {
const queuedRequest = this.requestQueue.dequeue();
if (this.requestMap.get(queuedRequest.operationId) === queuedRequest) {
this.requestMap.delete(queuedRequest.operationId);
this.scheduleRequest(queuedRequest);