mirror of
https://github.com/microsoft/TypeScript.git
synced 2026-02-04 21:53:42 -06:00
Fix get candidate for overload failure checking (#36744)
* getCandidateForOverloadFailure:call resolveUntypedCall This re-adds the missed errors and marks as used missed nodes from the user and RWC baselines. * Update baselines and remove new test It was redundant with the old tests * Defer resolveUntypedCall on resolution failure to give priority to parameter types fixed by overload signatures Co-authored-by: Wesley Wigham <wwigham@gmail.com>
This commit is contained in:
Nathan Shively-Sanders
GitHub
parent
6f079a4ebc
commit
01c86c749d
@ -22600,6 +22600,7 @@ namespace ts {
|
||||
|
||||
function checkJsxSelfClosingElementDeferred(node: JsxSelfClosingElement) {
|
||||
checkJsxOpeningLikeElementOrOpeningFragment(node);
|
||||
resolveUntypedCall(node); // ensure type arguments and parameters are typechecked, even if there is an arity error
|
||||
}
|
||||
|
||||
function checkJsxSelfClosingElement(node: JsxSelfClosingElement, _checkMode: CheckMode | undefined): Type {
|
||||
@ -24987,7 +24988,6 @@ namespace ts {
|
||||
}
|
||||
|
||||
// No signature was applicable. We have already reported the errors for the invalid signature.
|
||||
// If this is a type resolution session, e.g. Language Service, try to get better information than anySignature.
|
||||
function getCandidateForOverloadFailure(
|
||||
node: CallLikeExpression,
|
||||
candidates: Signature[],
|
||||
@ -24995,6 +24995,7 @@ namespace ts {
|
||||
hasCandidatesOutArray: boolean,
|
||||
): Signature {
|
||||
Debug.assert(candidates.length > 0); // Else should not have called this.
|
||||
checkNodeDeferred(node);
|
||||
// Normally we will combine overloads. Skip this if they have type parameters since that's hard to combine.
|
||||
// Don't do this if there is a `candidatesOutArray`,
|
||||
// because then we want the chosen best candidate to be one of the overloads, not a combination.
|
||||
@ -33913,6 +33914,16 @@ namespace ts {
|
||||
currentNode = node;
|
||||
instantiationCount = 0;
|
||||
switch (node.kind) {
|
||||
case SyntaxKind.CallExpression:
|
||||
case SyntaxKind.NewExpression:
|
||||
case SyntaxKind.TaggedTemplateExpression:
|
||||
case SyntaxKind.Decorator:
|
||||
case SyntaxKind.JsxOpeningElement:
|
||||
// These node kinds are deferred checked when overload resolution fails
|
||||
// To save on work, we ensure the arguments are checked just once, in
|
||||
// a deferred way
|
||||
resolveUntypedCall(node as CallLikeExpression);
|
||||
break;
|
||||
case SyntaxKind.FunctionExpression:
|
||||
case SyntaxKind.ArrowFunction:
|
||||
case SyntaxKind.MethodDeclaration:
|
||||
|
||||
@ -1,13 +1,15 @@
|
||||
tests/cases/compiler/baseCheck.ts(9,18): error TS2552: Cannot find name 'loc'. Did you mean 'ELoc'?
|
||||
tests/cases/compiler/baseCheck.ts(17,53): error TS2554: Expected 2 arguments, but got 1.
|
||||
tests/cases/compiler/baseCheck.ts(17,59): error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
|
||||
tests/cases/compiler/baseCheck.ts(18,62): error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
|
||||
tests/cases/compiler/baseCheck.ts(19,59): error TS2345: Argument of type '"hello"' is not assignable to parameter of type 'number'.
|
||||
tests/cases/compiler/baseCheck.ts(19,68): error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
|
||||
tests/cases/compiler/baseCheck.ts(22,9): error TS2304: Cannot find name 'x'.
|
||||
tests/cases/compiler/baseCheck.ts(23,7): error TS2304: Cannot find name 'x'.
|
||||
tests/cases/compiler/baseCheck.ts(26,9): error TS2304: Cannot find name 'x'.
|
||||
|
||||
|
||||
==== tests/cases/compiler/baseCheck.ts (7 errors) ====
|
||||
==== tests/cases/compiler/baseCheck.ts (9 errors) ====
|
||||
class C { constructor(x: number, y: number) { } }
|
||||
class ELoc extends C {
|
||||
constructor(x: number) {
|
||||
@ -31,12 +33,16 @@ tests/cases/compiler/baseCheck.ts(26,9): error TS2304: Cannot find name 'x'.
|
||||
~~~~~~~~~~~~~
|
||||
!!! error TS2554: Expected 2 arguments, but got 1.
|
||||
!!! related TS6210 tests/cases/compiler/baseCheck.ts:1:34: An argument for 'y' was not provided.
|
||||
~~~~
|
||||
!!! error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
|
||||
class E extends C { constructor(public z: number) { super(0, this.z) } }
|
||||
~~~~
|
||||
!!! error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
|
||||
class F extends C { constructor(public z: number) { super("hello", this.z) } } // first param type
|
||||
~~~~~~~
|
||||
!!! error TS2345: Argument of type '"hello"' is not assignable to parameter of type 'number'.
|
||||
~~~~
|
||||
!!! error TS17009: 'super' must be called before accessing 'this' in the constructor of a derived class.
|
||||
|
||||
function f() {
|
||||
if (x<10) {
|
||||
|
||||
@ -1,8 +1,12 @@
|
||||
tests/cases/compiler/grammarAmbiguities1.ts(8,3): error TS2365: Operator '<' cannot be applied to types '<T, U>(x: any) => any' and 'typeof A'.
|
||||
tests/cases/compiler/grammarAmbiguities1.ts(8,10): error TS2365: Operator '>' cannot be applied to types 'typeof B' and 'number'.
|
||||
tests/cases/compiler/grammarAmbiguities1.ts(8,10): error TS2554: Expected 1 arguments, but got 2.
|
||||
tests/cases/compiler/grammarAmbiguities1.ts(9,3): error TS2365: Operator '<' cannot be applied to types '<T, U>(x: any) => any' and 'typeof A'.
|
||||
tests/cases/compiler/grammarAmbiguities1.ts(9,10): error TS2365: Operator '>' cannot be applied to types 'typeof B' and 'number'.
|
||||
tests/cases/compiler/grammarAmbiguities1.ts(9,10): error TS2554: Expected 1 arguments, but got 2.
|
||||
|
||||
|
||||
==== tests/cases/compiler/grammarAmbiguities1.ts (2 errors) ====
|
||||
==== tests/cases/compiler/grammarAmbiguities1.ts (6 errors) ====
|
||||
class A { foo() { } }
|
||||
class B { bar() { }}
|
||||
function f(x) { return x; }
|
||||
@ -11,9 +15,17 @@ tests/cases/compiler/grammarAmbiguities1.ts(9,10): error TS2554: Expected 1 argu
|
||||
|
||||
f(g<A, B>(7));
|
||||
f(g < A, B > 7);
|
||||
~~~~~
|
||||
!!! error TS2365: Operator '<' cannot be applied to types '<T, U>(x: any) => any' and 'typeof A'.
|
||||
~~~~~
|
||||
!!! error TS2365: Operator '>' cannot be applied to types 'typeof B' and 'number'.
|
||||
~~~~~
|
||||
!!! error TS2554: Expected 1 arguments, but got 2.
|
||||
f(g < A, B > +(7));
|
||||
~~~~~
|
||||
!!! error TS2365: Operator '<' cannot be applied to types '<T, U>(x: any) => any' and 'typeof A'.
|
||||
~~~~~~~~
|
||||
!!! error TS2365: Operator '>' cannot be applied to types 'typeof B' and 'number'.
|
||||
~~~~~~~~
|
||||
!!! error TS2554: Expected 1 arguments, but got 2.
|
||||
|
||||
@ -1,12 +1,15 @@
|
||||
tests/cases/compiler/noImplicitAnyLoopCrash.ts(4,16): error TS2556: Expected 0 arguments, but got 1 or more.
|
||||
tests/cases/compiler/noImplicitAnyLoopCrash.ts(4,19): error TS2461: Type 'number' is not an array type.
|
||||
|
||||
|
||||
==== tests/cases/compiler/noImplicitAnyLoopCrash.ts (1 errors) ====
|
||||
==== tests/cases/compiler/noImplicitAnyLoopCrash.ts (2 errors) ====
|
||||
let foo = () => {};
|
||||
let bar;
|
||||
while (1) {
|
||||
bar = ~foo(...bar);
|
||||
~~~~~~
|
||||
!!! error TS2556: Expected 0 arguments, but got 1 or more.
|
||||
~~~
|
||||
!!! error TS2461: Type 'number' is not an array type.
|
||||
}
|
||||
|
||||
@ -1,9 +1,10 @@
|
||||
tests/cases/compiler/undeclaredModuleError.ts(1,21): error TS2307: Cannot find module 'fs'.
|
||||
tests/cases/compiler/undeclaredModuleError.ts(8,29): error TS2345: Argument of type '() => void' is not assignable to parameter of type '(stat: any, name: string) => boolean'.
|
||||
Type 'void' is not assignable to type 'boolean'.
|
||||
tests/cases/compiler/undeclaredModuleError.ts(11,41): error TS2304: Cannot find name 'IDoNotExist'.
|
||||
|
||||
|
||||
==== tests/cases/compiler/undeclaredModuleError.ts (2 errors) ====
|
||||
==== tests/cases/compiler/undeclaredModuleError.ts (3 errors) ====
|
||||
import fs = require('fs');
|
||||
~~~~
|
||||
!!! error TS2307: Cannot find module 'fs'.
|
||||
@ -20,6 +21,8 @@ tests/cases/compiler/undeclaredModuleError.ts(8,29): error TS2345: Argument of t
|
||||
} , (error: Error, files: {}[]) => {
|
||||
files.forEach((file) => {
|
||||
var fullPath = join(IDoNotExist);
|
||||
~~~~~~~~~~~
|
||||
!!! error TS2304: Cannot find name 'IDoNotExist'.
|
||||
} );
|
||||
} );
|
||||
} );
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user