mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-04 02:11:35 -06:00
CmdPal: Fix "Open location" menu item for Win32 and UWP (#42248)
## Summary of the Pull Request This PR fixes the regression of the "Open containing folder" context menu items: - For Win32 apps, the command now displays the correct icon, opens the folder containing the shortcut, and selects the file. - For UWP apps, it sets the same icon and item title as the equivalent command for Win32 apps. - For both, it updates the item's title to "Open file location" to align with the Windows 11 menu naming convention. <img width="1612" height="1106" alt="image" src="https://github.com/user-attachments/assets/27fa7557-862e-4453-ba7b-7ac3d0af21d2" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #42244 - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
This commit is contained in:
parent
df972447d4
commit
b89237ff94
@ -103,7 +103,8 @@ public class UWPApplication : IUWPApplication
|
||||
new CommandContextItem(
|
||||
new OpenFileCommand(Location)
|
||||
{
|
||||
Name = Resources.open_containing_folder,
|
||||
Icon = new("\uE838"),
|
||||
Name = Resources.open_location,
|
||||
})
|
||||
{
|
||||
RequestedShortcut = KeyChords.OpenFileLocation,
|
||||
|
||||
@ -207,7 +207,10 @@ public class Win32Program : IProgram
|
||||
});
|
||||
|
||||
commands.Add(new CommandContextItem(
|
||||
new OpenFileCommand(ParentDirectory))
|
||||
new ShowFileInFolderCommand(!string.IsNullOrEmpty(LnkFilePath) ? LnkFilePath : FullPath)
|
||||
{
|
||||
Name = Resources.open_location,
|
||||
})
|
||||
{
|
||||
RequestedShortcut = KeyChords.OpenFileLocation,
|
||||
});
|
||||
|
||||
@ -19,7 +19,7 @@ namespace Microsoft.CmdPal.Ext.Apps.Properties {
|
||||
// class via a tool like ResGen or Visual Studio.
|
||||
// To add or remove a member, edit your .ResX file then rerun ResGen
|
||||
// with the /str option, or rebuild your VS project.
|
||||
[global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "17.0.0.0")]
|
||||
[global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "18.0.0.0")]
|
||||
[global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
|
||||
[global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
|
||||
internal class Resources {
|
||||
@ -241,7 +241,7 @@ namespace Microsoft.CmdPal.Ext.Apps.Properties {
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Looks up a localized string similar to Open location.
|
||||
/// Looks up a localized string similar to Open file location.
|
||||
/// </summary>
|
||||
internal static string open_location {
|
||||
get {
|
||||
|
||||
@ -161,7 +161,7 @@
|
||||
<value>File</value>
|
||||
</data>
|
||||
<data name="open_location" xml:space="preserve">
|
||||
<value>Open location</value>
|
||||
<value>Open file location</value>
|
||||
</data>
|
||||
<data name="copy_path" xml:space="preserve">
|
||||
<value>Copy path</value>
|
||||
@ -237,4 +237,4 @@
|
||||
<data name="limit_none" xml:space="preserve">
|
||||
<value>Unlimited</value>
|
||||
</data>
|
||||
</root>
|
||||
</root>
|
||||
Loading…
x
Reference in New Issue
Block a user