From f4ff234ec8c7c5946c7d28add750988f7536a287 Mon Sep 17 00:00:00 2001 From: Louis Lam Date: Fri, 28 Nov 2025 20:41:44 +0800 Subject: [PATCH] [Push monitor] Fix: Prometheus update with incorrect value (#6436) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- server/model/monitor.js | 6 +++++- server/routers/api-router.js | 7 ++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/server/model/monitor.js b/server/model/monitor.js index 0b6be92d7..bb2c9e852 100644 --- a/server/model/monitor.js +++ b/server/model/monitor.js @@ -359,7 +359,11 @@ class Monitor extends BeanModel { let previousBeat = null; let retries = 0; - this.prometheus = new Prometheus(this, await this.getTags()); + try { + this.prometheus = new Prometheus(this, await this.getTags()); + } catch (e) { + log.error("prometheus", "Please submit an issue to our GitHub repo. Prometheus update error: ", e.message); + } const beat = async () => { diff --git a/server/routers/api-router.js b/server/routers/api-router.js index b00dbc02d..9c9a7e7e9 100644 --- a/server/routers/api-router.js +++ b/server/routers/api-router.js @@ -119,7 +119,12 @@ router.all("/api/push/:pushToken", async (request, response) => { io.to(monitor.user_id).emit("heartbeat", bean.toJSON()); Monitor.sendStats(io, monitor.id, monitor.user_id); - new Prometheus(monitor).update(bean, undefined); + + try { + new Prometheus(monitor, []).update(bean, undefined); + } catch (e) { + log.error("prometheus", "Please submit an issue to our GitHub repo. Prometheus update error: ", e.message); + } response.json({ ok: true,