Stefan Agner 8030b346e0
Load resolution evaluation, check and fixups early (#5696)
* Load resolution evaluation, check and fixups early

Before #5652, these modules were loaded in the constructor, hence early
in `initialize_coresys()`. Moving them late actually exposed an issue
where NetworkManager connectivity setter couldn't get the
`connectivity_check` evaluation, leading to an exception early in
bootstrap.

Technically, it might be safe to load the resolution modules only in
`Core.connect()`, however then we'd have to load them separately for
pytest. Let's go conservative and load them the same place where they
got loaded before #5652.

* Load resolution modules in a single executor call

* Fix pytest
2025-02-28 16:59:22 +01:00

119 lines
3.6 KiB
Python

"""Test check."""
# pylint: disable=import-error,protected-access
from unittest.mock import AsyncMock, patch
import pytest
from supervisor.const import CoreState
from supervisor.coresys import CoreSys
from supervisor.exceptions import ResolutionNotFound
from supervisor.resolution.const import ContextType, IssueType
from supervisor.resolution.data import Issue
from supervisor.resolution.validate import get_valid_modules
@pytest.fixture(autouse=True)
def fixture_mock_dns_query():
"""Mock aiodns query."""
with (
patch(
"supervisor.resolution.checks.dns_server.DNSResolver.query",
new_callable=AsyncMock,
),
patch(
"supervisor.resolution.checks.dns_server_ipv6.DNSResolver.query",
new_callable=AsyncMock,
),
):
yield
async def test_check_setup(coresys: CoreSys):
"""Test check for setup."""
coresys.core.state = CoreState.SETUP
with patch(
"supervisor.resolution.checks.free_space.CheckFreeSpace.run_check",
return_value=False,
) as free_space:
await coresys.resolution.check.check_system()
free_space.assert_not_called()
async def test_check_running(coresys: CoreSys):
"""Test check for setup."""
coresys.core.state = CoreState.RUNNING
with patch(
"supervisor.resolution.checks.free_space.CheckFreeSpace.run_check",
return_value=False,
) as free_space:
await coresys.resolution.check.check_system()
free_space.assert_called_once()
async def test_if_check_make_issue(coresys: CoreSys):
"""Test check for setup."""
free_space = Issue(IssueType.FREE_SPACE, ContextType.SYSTEM)
coresys.core.state = CoreState.RUNNING
coresys.security.content_trust = False
with patch("shutil.disk_usage", return_value=(1, 1, 1)):
await coresys.resolution.check.check_system()
assert free_space in coresys.resolution.issues
async def test_if_check_cleanup_issue(coresys: CoreSys):
"""Test check for setup."""
free_space = Issue(IssueType.FREE_SPACE, ContextType.SYSTEM)
coresys.core.state = CoreState.RUNNING
coresys.security.content_trust = False
with patch("shutil.disk_usage", return_value=(1, 1, 1)):
await coresys.resolution.check.check_system()
assert free_space in coresys.resolution.issues
with patch("shutil.disk_usage", return_value=(42, 42, 2 * (1024.0**3))):
await coresys.resolution.check.check_system()
assert free_space not in coresys.resolution.issues
async def test_enable_disable_checks(coresys: CoreSys):
"""Test enable and disable check."""
coresys.core.state = CoreState.RUNNING
free_space = coresys.resolution.check.get("free_space")
# Ensure the check was enabled
assert free_space.enabled
free_space.enabled = False
assert not free_space.enabled
with patch(
"supervisor.resolution.checks.free_space.CheckFreeSpace.run_check",
return_value=False,
) as free_space:
await coresys.resolution.check.check_system()
free_space.assert_not_called()
free_space.enabled = True
assert free_space.enabled
async def test_get_checks(coresys: CoreSys):
"""Test get check with slug."""
with pytest.raises(ResolutionNotFound):
coresys.resolution.check.get("does_not_exsist")
assert coresys.resolution.check.get("free_space")
async def test_dynamic_check_loader(coresys: CoreSys):
"""Test dynamic check loader, this ensures that all checks have defined a setup function."""
coresys.resolution.check.load_modules()
for check in get_valid_modules("checks"):
assert check in coresys.resolution.check._checks