mirror of
https://github.com/home-assistant/iOS.git
synced 2026-02-04 11:42:39 -06:00
cd86bc3ade
## Summary
Enables audio playback in the native WebRTC video player and adds
mute/unmute controls. The previous implementation had audio disabled via
`useManualAudio = true` to avoid microphone permission requests.
**Key changes:**
- **Audio session configuration**: Uses
`AVAudioSession.Category.playback` for receive-only audio (no microphone
access required)
- **Remote audio track management**: Properly extracts audio track from
peer connection transceivers after remote SDP is set
- **Mute/unmute UI**: Added button at bottom-left of player using SF
Symbols (`speaker.wave.fill` / `speaker.slash.fill`)
- **State synchronization**: ViewModel mute state always reflects actual
audio track state
**Technical details:**
```swift
// Audio session configured for playback only
audioSession.setCategory(AVAudioSession.Category.playback.rawValue)
audioSession.setMode(AVAudioSession.Mode.spokenAudio.rawValue)
// Remote audio track extracted after SDP negotiation
remoteAudioTrack = peerConnection.transceivers
.first(where: { $0.mediaType == .audio })?
.receiver.track as? RTCAudioTrack
```
The implementation removes microphone-related warnings from the
experimental disclaimer.
## Screenshots
N/A - Audio feature, no visual changes beyond the mute button icon which
follows existing control patterns.
## Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
## Any other notes
Audio mode uses `.spokenAudio` for optimal voice/camera audio playback.
The mute button follows the same auto-hide behavior as other player
controls (3-second timeout).
<!-- START COPILOT CODING AGENT SUFFIX -->
<!-- START COPILOT ORIGINAL PROMPT -->
<details>
<summary>Original prompt</summary>
> Let's start supporting audio on WebRTCVideoPlayerView, including
control mute/unmute
</details>
<!-- START COPILOT CODING AGENT TIPS -->
---
✨ Let Copilot coding agent [set things up for
you](https://github.com/home-assistant/iOS/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bgoncal <5808343+bgoncal@users.noreply.github.com>
48 lines
1.3 KiB
Swift
48 lines
1.3 KiB
Swift
#if !os(watchOS)
|
|
import SwiftUI
|
|
|
|
public struct ModalCloseButton: View {
|
|
@Environment(\.dismiss) private var dismiss
|
|
private let alternativeAction: (() -> Void)?
|
|
private let tint: Color
|
|
|
|
/// When alternative action is set, the button will execute this action instead of dismissing the view.
|
|
public init(
|
|
tint: Color = Color.secondary,
|
|
alternativeAction: (() -> Void)? = nil
|
|
) {
|
|
self.alternativeAction = alternativeAction
|
|
self.tint = tint
|
|
}
|
|
|
|
public var body: some View {
|
|
Button(action: {
|
|
tapAction()
|
|
}, label: {
|
|
Image(systemSymbol: .xmark)
|
|
.resizable()
|
|
.frame(width: 16, height: 16)
|
|
.modify { view in
|
|
if #available(iOS 26.0, *) {
|
|
view
|
|
.padding(DesignSystem.Spaces.oneAndHalf)
|
|
.glassEffect(.clear.interactive(), in: .circle)
|
|
} else {
|
|
view
|
|
}
|
|
}
|
|
})
|
|
.buttonStyle(.plain)
|
|
.foregroundStyle(tint)
|
|
}
|
|
|
|
private func tapAction() {
|
|
if let alternativeAction {
|
|
alternativeAction()
|
|
} else {
|
|
dismiss()
|
|
}
|
|
}
|
|
}
|
|
#endif
|