mirror of
https://github.com/home-assistant/iOS.git
synced 2026-04-12 05:08:23 -05:00
b8898cc6fd
## Summary
Migrates SettingsViewController from UIKit/Eureka to SwiftUI. macOS uses
NavigationSplitView (sidebar + detail), iOS uses NavigationStack with
list navigation.
**Changes:**
- **SettingsView.swift** (new): SwiftUI implementation with
platform-specific navigation
- macOS: Sidebar with setting categories, NavigationStack in detail pane
- iOS: List-based navigation with NavigationStack
- Platform filtering: macOS hides gestures, watch, CarPlay, NFC, help,
whatsNew
- Supports `contentSections` parameter for filtering displayed sections
(defaults to `.all`)
- ServersObserver for real-time server updates via ServerObserver
protocol
- Wrapper views embed UIKit controllers not yet migrated (location,
notifications, NFC, complications, actions)
- **SettingsItem.swift**: Enhanced with `visibleCases(for:)` method to
filter items based on contentSections parameter
- **SettingsSceneDelegate.swift**: Simplified from 189→36 lines
- Returns SwiftUI SettingsView for all platforms
- Removed UINavigationController management, NSToolbar delegate
- **WebViewController.swift**, **WebViewExternalMessageHandler.swift**,
**ConnectionSecurityLevelBlockView.swift**: Updated to present SwiftUI
SettingsView
- **SettingsViewController.swift**: Deleted (253 lines removed) - all
functionality migrated to SwiftUI
Example usage with content filtering:
```swift
// Show all sections (default)
SettingsView()
// Show only servers section
SettingsView(contentSections: .servers)
```
Example navigation on macOS:
```swift
NavigationSplitView {
List(selection: $selectedItem) {
ForEach(SettingsItem.visibleCases(for: contentSections)) { item in
NavigationLink(value: item) {
Label(item.title) { item.icon }
}
}
}
} detail: {
NavigationStack {
if let selectedItem {
selectedItem.destinationView
}
}
}
```
## Screenshots
## Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
## Any other notes
Complete migration from UIKit/Eureka to SwiftUI with full feature parity
including contentSections support. UIKit controllers
(SettingsDetailViewController, NotificationSettingsViewController, etc.)
remain embedded via `embed()` function until individually migrated.
<!-- START COPILOT CODING AGENT SUFFIX -->
<details>
<summary>Original prompt</summary>
> Migrate SettingsViewController to SwiftUI, on macOS it should be a
split view (sidebar + content). If needed to embed UIKit controllers in
the middle use "embed(<UIViewController>)"
</details>
<!-- START COPILOT CODING AGENT TIPS -->
---
💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bgoncal <5808343+bgoncal@users.noreply.github.com>
54 lines
2.3 KiB
Swift
54 lines
2.3 KiB
Swift
import FirebaseMessaging
|
|
import Shared
|
|
import SwiftUI
|
|
|
|
struct PrivacyView: View {
|
|
@State private var messaging: Bool = Current.settingsStore.privacy.messaging
|
|
@State private var alerts: Bool = Current.settingsStore.privacy.alerts
|
|
@State private var crashes: Bool = Current.settingsStore.privacy.crashes
|
|
@State private var analytics: Bool = Current.settingsStore.privacy.analytics
|
|
|
|
var body: some View {
|
|
List {
|
|
AppleLikeListTopRowHeader(
|
|
image: .lockIcon,
|
|
title: L10n.SettingsDetails.Privacy.title,
|
|
subtitle: L10n.SettingsDetails.Privacy.body
|
|
)
|
|
Section(footer: Text(L10n.SettingsDetails.Privacy.Messaging.description)) {
|
|
Toggle(L10n.SettingsDetails.Privacy.Messaging.title, isOn: $messaging)
|
|
.onChange(of: messaging) { value in
|
|
Current.settingsStore.privacy.messaging = value
|
|
Messaging.messaging().isAutoInitEnabled = value
|
|
}
|
|
}
|
|
Section(footer: Text(L10n.SettingsDetails.Privacy.Alerts.description)) {
|
|
Toggle(L10n.SettingsDetails.Privacy.Alerts.title, isOn: $alerts)
|
|
.onChange(of: alerts) { value in
|
|
Current.settingsStore.privacy.alerts = value
|
|
}
|
|
}
|
|
if Current.crashReporter.hasCrashReporter {
|
|
Section(footer: Text(L10n.SettingsDetails.Privacy.CrashReporting.description)) {
|
|
Toggle(L10n.SettingsDetails.Privacy.CrashReporting.title, isOn: $crashes)
|
|
.onChange(of: crashes) { value in
|
|
Current.settingsStore.privacy.crashes = value
|
|
}
|
|
}
|
|
}
|
|
if Current.crashReporter.hasAnalytics {
|
|
Section(footer: Text(L10n.SettingsDetails.Privacy.Analytics.genericDescription)) {
|
|
Toggle(L10n.SettingsDetails.Privacy.Analytics.genericTitle, isOn: $analytics)
|
|
.onChange(of: analytics) { value in
|
|
Current.settingsStore.privacy.analytics = value
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#Preview {
|
|
PrivacyView()
|
|
}
|