gnuradio/gnuradio-companion
1
0
Fork 0
mirror of https://github.com/gnuradio/gnuradio-companion.git synced 2025-12-13 19:47:05 -06:00
Code Issues Packages Projects Releases Wiki Activity
gnuradio-companion/gui/VariableEditor.py
Volker Schroer 747a7fb143 grc: Variable Editor keyError 
Run grc, add an import block in the variable editor
edit the value for the import block in the variable editor,
for instance enter import math.

Then you get an error

  File "/usr/local/gnuradio/lib64/python3.12/site-packages/gnuradio/grc/gui/VariableEditor.py", line 243, in _handle_value_edited_cb
    block.params['import'].set_value(new_text)
    ~~~~~~~~~~~~^^^^^^^^^^
KeyError: 'import'

Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
2024-05-21 09:21:03 -04:00

359 lines
14 KiB
Python
Raw Permalink Blame History

"""
Copyright 2015, 2016 Free Software Foundation, Inc.
This file is part of GNU Radio
SPDX-License-Identifier: GPL-2.0-or-later
"""
from gi.repository import Gtk, Gdk, GObject
from . import Actions, Constants, Utils
BLOCK_INDEX = 0
ID_INDEX = 1
class VariableEditorContextMenu(Gtk.Menu):
""" A simple context menu for our variable editor """
def __init__(self, var_edit):
Gtk.Menu.__init__(self)
self.imports = Gtk.MenuItem(label="Add _Import")
self.imports.connect(
'activate', var_edit.handle_action, var_edit.ADD_IMPORT)
self.add(self.imports)
self.variables = Gtk.MenuItem(label="Add _Variable")
self.variables.connect(
'activate', var_edit.handle_action, var_edit.ADD_VARIABLE)
self.add(self.variables)
self.add(Gtk.SeparatorMenuItem())
self.enable = Gtk.MenuItem(label="_Enable")
self.enable.connect(
'activate', var_edit.handle_action, var_edit.ENABLE_BLOCK)
self.disable = Gtk.MenuItem(label="_Disable")
self.disable.connect(
'activate', var_edit.handle_action, var_edit.DISABLE_BLOCK)
self.add(self.enable)
self.add(self.disable)
self.add(Gtk.SeparatorMenuItem())
self.delete = Gtk.MenuItem(label="_Delete")
self.delete.connect(
'activate', var_edit.handle_action, var_edit.DELETE_BLOCK)
self.add(self.delete)
self.add(Gtk.SeparatorMenuItem())
self.properties = Gtk.MenuItem(label="_Properties...")
self.properties.connect(
'activate', var_edit.handle_action, var_edit.OPEN_PROPERTIES)
self.add(self.properties)
self.show_all()
def update_sensitive(self, selected, enabled=False):
self.delete.set_sensitive(selected)
self.properties.set_sensitive(selected)
self.enable.set_sensitive(selected and not enabled)
self.disable.set_sensitive(selected and enabled)
class VariableEditor(Gtk.VBox):
# Actions that are handled by the editor
ADD_IMPORT = 0
ADD_VARIABLE = 1
OPEN_PROPERTIES = 2
DELETE_BLOCK = 3
DELETE_CONFIRM = 4
ENABLE_BLOCK = 5
DISABLE_BLOCK = 6
__gsignals__ = {
'create_new_block': (GObject.SignalFlags.RUN_FIRST, None, (str,)),
'remove_block': (GObject.SignalFlags.RUN_FIRST, None, (str,))
}
def __init__(self):
Gtk.VBox.__init__(self)
config = Gtk.Application.get_default().config
self._block = None
self._mouse_button_pressed = False
self._imports = []
self._variables = []
# Only use the model to store the block reference and name.
# Generate everything else dynamically
self.treestore = Gtk.TreeStore(GObject.TYPE_PYOBJECT, # Block reference
GObject.TYPE_STRING) # Category and block name
self.treeview = Gtk.TreeView(model=self.treestore)
self.treeview.set_enable_search(False)
self.treeview.set_search_column(-1)
# self.treeview.set_enable_search(True)
# self.treeview.set_search_column(ID_INDEX)
self.treeview.get_selection().set_mode(Gtk.SelectionMode.SINGLE)
self.treeview.set_headers_visible(True)
self.treeview.connect('button-press-event',
self._handle_mouse_button_press)
self.treeview.connect('button-release-event',
self._handle_mouse_button_release)
self.treeview.connect('motion-notify-event',
self._handle_motion_notify)
self.treeview.connect('key-press-event', self._handle_key_button_press)
# Block Name or Category
self.id_cell = Gtk.CellRendererText()
self.id_cell.connect('edited', self._handle_name_edited_cb)
id_column = Gtk.TreeViewColumn("ID", self.id_cell, text=ID_INDEX)
id_column.set_name("id")
id_column.set_resizable(True)
id_column.set_max_width(Utils.scale_scalar(300))
id_column.set_min_width(Utils.scale_scalar(80))
id_column.set_fixed_width(Utils.scale_scalar(120))
id_column.set_sizing(Gtk.TreeViewColumnSizing.FIXED)
id_column.set_cell_data_func(self.id_cell, self.set_properties)
self.id_column = id_column
self.treeview.append_column(id_column)
self.treestore.set_sort_column_id(ID_INDEX, Gtk.SortType.ASCENDING)
# For forcing resize
self._col_width = 0
# Block Value
self.value_cell = Gtk.CellRendererText()
self.value_cell.connect('edited', self._handle_value_edited_cb)
value_column = Gtk.TreeViewColumn("Value", self.value_cell)
value_column.set_name("value")
value_column.set_resizable(False)
value_column.set_expand(True)
value_column.set_min_width(Utils.scale_scalar(100))
value_column.set_sizing(Gtk.TreeViewColumnSizing.AUTOSIZE)
value_column.set_cell_data_func(self.value_cell, self.set_value)
self.value_column = value_column
self.treeview.append_column(value_column)
# Block Actions (Add, Remove)
self.action_cell = Gtk.CellRendererPixbuf()
value_column.pack_start(self.action_cell, False)
value_column.set_cell_data_func(self.action_cell, self.set_icon)
# Make the scrolled window to hold the tree view
scrolled_window = Gtk.ScrolledWindow()
scrolled_window.set_policy(
Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
scrolled_window.add(self.treeview)
scrolled_window.set_size_request(
Constants.DEFAULT_BLOCKS_WINDOW_WIDTH, -1)
self.pack_start(scrolled_window, True, True, 0)
# Context menus
self._context_menu = VariableEditorContextMenu(self)
self._confirm_delete = config.variable_editor_confirm_delete()
# Sets cell contents
def set_icon(self, col, cell, model, iter, data):
block = model.get_value(iter, BLOCK_INDEX)
cell.set_property('icon-name', 'window-close' if block else 'list-add')
def set_value(self, col, cell, model, iter, data):
sp = cell.set_property
block = model.get_value(iter, BLOCK_INDEX)
# Set the default properties for this column first.
# Some set in set_properties() may be overridden (editable for advanced variable blocks)
self.set_properties(col, cell, model, iter, data)
# Set defaults
value = None
self.set_tooltip_text(None)
# Block specific values
if block:
if block.key == 'import':
value = block.params['imports'].get_value()
elif block.key != "variable":
value = "<Open Properties>"
sp('editable', False)
sp('foreground', '#0D47A1')
else:
value = block.params['value'].get_value()
# Check if there are errors in the blocks.
# Show the block error as a tooltip
error_message = block.get_error_messages()
if len(error_message) > 0:
# Set the error message to the last error in the list.
# This should be the first message generated
self.set_tooltip_text(error_message[-1])
else:
# Evaluate and show the value (if it is a variable)
if block.is_variable:
value = str(block.evaluate(block.value))
# Always set the text value.
sp('text', value)
def set_properties(self, col, cell, model, iter, data):
sp = cell.set_property
block = model.get_value(iter, BLOCK_INDEX)
# Set defaults
sp('sensitive', True)
sp('editable', False)
sp('foreground', None)
# Block specific changes
if block:
if not block.enabled:
# Disabled block. But, this should still be editable
sp('editable', True)
sp('foreground', 'gray')
else:
sp('editable', True)
if block.get_error_messages():
sp('foreground', 'red')
def update_gui(self, blocks):
self._imports = [block for block in blocks if block.is_import]
self._variables = [block for block in blocks if block.is_variable]
self._rebuild()
self.treeview.expand_all()
def _rebuild(self, *args):
self.treestore.clear()
imports = self.treestore.append(None, [None, 'Imports'])
variables = self.treestore.append(None, [None, 'Variables'])
for block in self._imports:
self.treestore.append(
imports, [block, block.params['id'].get_value()])
for block in sorted(self._variables, key=lambda v: v.name):
self.treestore.append(
variables, [block, block.params['id'].get_value()])
def _handle_name_edited_cb(self, cell, path, new_text):
block = self.treestore[path][BLOCK_INDEX]
block.params['id'].set_value(new_text)
Actions.VARIABLE_EDITOR_UPDATE()
def _handle_value_edited_cb(self, cell, path, new_text):
block = self.treestore[path][BLOCK_INDEX]
if block.is_import:
block.params['imports'].set_value(new_text)
else:
block.params['value'].set_value(new_text)
Actions.VARIABLE_EDITOR_UPDATE()
def handle_action(self, item, key, event=None):
"""
Single handler for the different actions that can be triggered by the context menu,
key presses or mouse clicks. Also triggers an update of the flow graph and editor.
"""
if key == self.ADD_IMPORT:
self.emit('create_new_block', 'import')
elif key == self.ADD_VARIABLE:
self.emit('create_new_block', 'variable')
elif key == self.OPEN_PROPERTIES:
# TODO: This probably isn't working because the action doesn't expect a parameter
# Actions.BLOCK_PARAM_MODIFY()
pass
elif key == self.DELETE_BLOCK:
self.emit('remove_block', self._block.name)
elif key == self.DELETE_CONFIRM:
if self._confirm_delete:
# Create a context menu to confirm the delete operation
confirmation_menu = Gtk.Menu()
block_id = self._block.params['id'].get_value().replace(
"_", "__")
confirm = Gtk.MenuItem(label="Delete {}".format(block_id))
confirm.connect('activate', self.handle_action,
self.DELETE_BLOCK)
confirmation_menu.add(confirm)
confirmation_menu.show_all()
confirmation_menu.popup(
None, None, None, None, event.button, event.time)
else:
self.handle_action(None, self.DELETE_BLOCK, None)
elif key == self.ENABLE_BLOCK:
self._block.state = 'enabled'
elif key == self.DISABLE_BLOCK:
self._block.state = 'disabled'
Actions.VARIABLE_EDITOR_UPDATE()
def _handle_mouse_button_press(self, widget, event):
"""
Handles mouse button for several different events:
- Double Click to open properties for advanced blocks
- Click to add/remove blocks
"""
# Save the column width to see if it changes on button_release
self._mouse_button_pressed = True
self._col_width = self.id_column.get_width()
path = widget.get_path_at_pos(int(event.x), int(event.y))
if path:
# If there is a valid path, then get the row, column and block selected.
row = self.treestore[path[0]]
col = path[1]
self._block = row[BLOCK_INDEX]
if event.button == 1 and col.get_name() == "value":
# Make sure this has a block (not the import/variable rows)
if self._block and event.type == Gdk.EventType._2BUTTON_PRESS:
# Open the advanced dialog if it is a gui variable
if self._block.key not in ("variable", "import"):
self.handle_action(
None, self.OPEN_PROPERTIES, event=event)
return True
if event.type == Gdk.EventType.BUTTON_PRESS:
# User is adding/removing blocks
# Make sure this is the action cell (Add/Remove Icons)
if path[2] > col.cell_get_position(self.action_cell)[0]:
if row[1] == "Imports":
# Add a new import block.
self.handle_action(
None, self.ADD_IMPORT, event=event)
elif row[1] == "Variables":
# Add a new variable block
self.handle_action(
None, self.ADD_VARIABLE, event=event)
else:
self.handle_action(
None, self.DELETE_CONFIRM, event=event)
return True
elif event.button == 3 and event.type == Gdk.EventType.BUTTON_PRESS:
if self._block:
self._context_menu.update_sensitive(
True, enabled=self._block.enabled)
else:
self._context_menu.update_sensitive(False)
self._context_menu.popup(
None, None, None, None, event.button, event.time)
# Null handler. Stops the treeview from handling double click events.
if event.type == Gdk.EventType._2BUTTON_PRESS:
return True
return False
def _handle_mouse_button_release(self, widget, event):
self._mouse_button_pressed = False
return False
def _handle_motion_notify(self, widget, event):
# Check to see if the column size has changed
if self._mouse_button_pressed and self.id_column.get_width() != self._col_width:
self.value_column.queue_resize()
return False
def _handle_key_button_press(self, widget, event):
model, path = self.treeview.get_selection().get_selected_rows()
if path and self._block:
if self._block.enabled and event.string == "d":
self.handle_action(None, self.DISABLE_BLOCK, None)
return True
elif not self._block.enabled and event.string == "e":
self.handle_action(None, self.ENABLE_BLOCK, None)
return True
return False
Reference in New Issue View Git Blame Copy Permalink