Files
git/fsmonitor-settings.c
Johannes Schindelin 80da22829c fixup! fsmonitor: reintroduce core.useBuiltinFSMonitor
Under certain (not quite easy to force, apparently) circumstances, a Git
process that just warned about the deprecated config setting will spawn
another Git process that then _also_ warns about that config setting.

Let's try to tone that down by setting an environment variable that
indicates that this process and all of its children no longer need to
tell the user about this deprecation.

Note: This patch does not help in situations where, say, scripts call
Git multiple times and each of those times Git prints this deprecation
notice. It is unclear whether we can do anything about this because
those Git processes would have to signal to their _parent_ process that
the advice was already provided.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2022-04-07 10:57:13 +02:00

115 lines
2.5 KiB
C

#include "cache.h"
#include "config.h"
#include "repository.h"
#include "fsmonitor-settings.h"
/*
* We keep this structure defintion private and have getters
* for all fields so that we can lazy load it as needed.
*/
struct fsmonitor_settings {
enum fsmonitor_mode mode;
char *hook_path;
};
static void lookup_fsmonitor_settings(struct repository *r)
{
struct fsmonitor_settings *s;
const char *const_str;
int bool_value;
if (r->settings.fsmonitor)
return;
CALLOC_ARRAY(s, 1);
s->mode = FSMONITOR_MODE_DISABLED;
r->settings.fsmonitor = s;
/*
* Overload the existing "core.fsmonitor" config setting (which
* has historically been either unset or a hook pathname) to
* now allow a boolean value to enable the builtin FSMonitor
* or to turn everything off. (This does imply that you can't
* use a hook script named "true" or "false", but that's OK.)
*/
switch (repo_config_get_maybe_bool(r, "core.fsmonitor", &bool_value)) {
case 0: /* config value was set to <bool> */
if (bool_value)
fsm_settings__set_ipc(r);
return;
case 1: /* config value was unset */
const_str = getenv("GIT_TEST_FSMONITOR");
break;
case -1: /* config value set to an arbitrary string */
if (repo_config_get_pathname(r, "core.fsmonitor", &const_str))
return; /* should not happen */
break;
default: /* should not happen */
return;
}
if (!const_str || !*const_str)
return;
fsm_settings__set_hook(r, const_str);
}
enum fsmonitor_mode fsm_settings__get_mode(struct repository *r)
{
if (!r)
r = the_repository;
lookup_fsmonitor_settings(r);
return r->settings.fsmonitor->mode;
}
const char *fsm_settings__get_hook_path(struct repository *r)
{
if (!r)
r = the_repository;
lookup_fsmonitor_settings(r);
return r->settings.fsmonitor->hook_path;
}
void fsm_settings__set_ipc(struct repository *r)
{
if (!r)
r = the_repository;
lookup_fsmonitor_settings(r);
r->settings.fsmonitor->mode = FSMONITOR_MODE_IPC;
FREE_AND_NULL(r->settings.fsmonitor->hook_path);
}
void fsm_settings__set_hook(struct repository *r, const char *path)
{
if (!r)
r = the_repository;
lookup_fsmonitor_settings(r);
r->settings.fsmonitor->mode = FSMONITOR_MODE_HOOK;
FREE_AND_NULL(r->settings.fsmonitor->hook_path);
r->settings.fsmonitor->hook_path = strdup(path);
}
void fsm_settings__set_disabled(struct repository *r)
{
if (!r)
r = the_repository;
lookup_fsmonitor_settings(r);
r->settings.fsmonitor->mode = FSMONITOR_MODE_DISABLED;
FREE_AND_NULL(r->settings.fsmonitor->hook_path);
}