mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 00:58:30 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
47 lines
1.4 KiB
C
47 lines
1.4 KiB
C
#ifndef COLUMN_H
|
|
#define COLUMN_H
|
|
|
|
#define COL_LAYOUT_MASK 0x000F
|
|
#define COL_ENABLE_MASK 0x0030 /* always, never or auto */
|
|
#define COL_PARSEOPT 0x0040 /* --column is given from cmdline */
|
|
#define COL_DENSE 0x0080 /* Shrink columns when possible,
|
|
making space for more columns */
|
|
|
|
#define COL_DISABLED 0x0000 /* must be zero */
|
|
#define COL_ENABLED 0x0010
|
|
#define COL_AUTO 0x0020
|
|
|
|
#define COL_LAYOUT(c) ((c) & COL_LAYOUT_MASK)
|
|
#define COL_COLUMN 0 /* Fill columns before rows */
|
|
#define COL_ROW 1 /* Fill rows before columns */
|
|
#define COL_PLAIN 15 /* one column */
|
|
|
|
#define explicitly_enable_column(c) \
|
|
(((c) & COL_PARSEOPT) && column_active(c))
|
|
|
|
struct column_options {
|
|
int width;
|
|
int padding;
|
|
const char *indent;
|
|
const char *nl;
|
|
};
|
|
|
|
struct option;
|
|
int parseopt_column_callback(const struct option *, const char *, int);
|
|
int git_column_config(const char *var, const char *value,
|
|
const char *command, unsigned int *colopts);
|
|
int finalize_colopts(unsigned int *colopts, int stdout_is_tty);
|
|
static inline int column_active(unsigned int colopts)
|
|
{
|
|
return (colopts & COL_ENABLE_MASK) == COL_ENABLED;
|
|
}
|
|
|
|
struct string_list;
|
|
void print_columns(const struct string_list *list, unsigned int colopts,
|
|
const struct column_options *opts);
|
|
|
|
int run_column_filter(int colopts, const struct column_options *);
|
|
int stop_column_filter(void);
|
|
|
|
#endif
|