Tanay Abhra c8466645ed make config --add behave correctly for empty and NULL values ...

Currently if we have a config file like,
[foo]
        baz
        bar =

and we try something like, "git config --add foo.baz roll", Git will
segfault. Moreover, for "git config --add foo.bar roll", it will
overwrite the original value instead of appending after the existing
empty value.

The problem lies with the regexp used for simulating --add in
`git_config_set_multivar_in_file()`, "^$", which in ideal case should
not match with any string but is true for empty strings. Instead use a
regexp like "a^" which can not be true for any string, empty or not.

For removing the segfault add a check for NULL values in `matches()` in
config.c.

Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

2014-08-18 10:45:59 -07:00

..

add.c

Merge branch 'fr/add-interactive-argv-array'

2014-03-28 13:51:05 -07:00

annotate.c

annotate: use argv_array

2014-07-16 11:10:11 -07:00

apply.c

use xmemdupz() to allocate copies of strings given by start and length

2014-07-21 10:37:02 -07:00

archive.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

bisect--helper.c

Replace deprecated OPT_BOOLEAN by OPT_BOOL

2013-08-05 11:32:19 -07:00

blame.c

move setting of object->type to alloc_* functions

2014-07-28 10:14:33 -07:00

branch.c

use wildmatch() directly without fnmatch() wrapper

2014-02-20 14:15:46 -08:00

bundle.c

…

cat-file.c

Merge branch 'jk/warn-on-object-refname-ambiguity'

2014-03-25 11:07:36 -07:00

check-attr.c

Merge branch 'jc/check-attr-honor-working-tree' into maint

2014-03-18 14:03:03 -07:00

check-ignore.c

Merge branch 'dw/check-ignore-sans-index'

2013-09-20 12:37:32 -07:00

check-mailmap.c

builtin: add git-check-mailmap command

2013-07-13 10:19:37 -07:00

check-ref-format.c

…

checkout-index.c

Merge branch 'nd/lift-path-max'

2013-10-30 12:10:56 -07:00

checkout.c

Merge branch 'jl/nor-or-nand-and' into maint

2014-04-09 12:03:26 -07:00

clean.c

use xcalloc() to allocate zero-initialized memory

2014-07-21 10:30:21 -07:00

clone.c

builtin/clone.c: detect a clone starting at a tag correctly

2014-06-23 14:31:35 -07:00

column.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

commit-tree.c

commit_tree: take a pointer/len pair rather than a const strbuf

2014-06-12 10:29:41 -07:00

commit.c

Merge branch 'jk/commit-buffer-length' into maint

2014-07-16 11:16:38 -07:00

config.c

make config --add behave correctly for empty and NULL values

2014-08-18 10:45:59 -07:00

count-objects.c

…

credential.c

…

describe.c

Merge branch 'nd/no-more-fnmatch'

2014-03-14 14:25:31 -07:00

diff-files.c

convert read_cache_preload() to take struct pathspec

2013-07-15 10:56:08 -07:00

diff-index.c

convert read_cache_preload() to take struct pathspec

2013-07-15 10:56:08 -07:00

diff-tree.c

diff-tree: avoid lookup_unknown_object

2014-07-28 10:14:34 -07:00

diff.c

Merge branch 'tg/diff-no-index-refactor'

2013-12-27 14:58:17 -08:00

fast-export.c

commit: record buffer length in cache

2014-06-13 12:09:38 -07:00

fetch-pack.c

Merge branch 'nd/shallow-clone'

2014-01-17 12:21:20 -08:00

fetch.c

Merge branch 'ep/varscope'

2014-02-27 14:01:30 -08:00

fmt-merge-msg.c

commit: record buffer length in cache

2014-06-13 12:09:38 -07:00

for-each-ref.c

use wildmatch() directly without fnmatch() wrapper

2014-02-20 14:15:46 -08:00

fsck.c

provide a helper to free commit buffer

2014-06-13 12:07:47 -07:00

gc.c

Merge branch 'nd/daemonize-gc' into maint

2014-06-25 11:47:36 -07:00

get-tar-commit-id.c

stop installing git-tar-tree link

2013-12-03 12:35:22 -08:00

grep.c

Merge branch 'sk/spawn-less-case-insensitively-from-grep-O-i' into maint

2014-06-25 11:47:49 -07:00

hash-object.c

hash-object: replace stdin parsing OPT_BOOLEAN by OPT_COUNTUP

2013-08-07 08:30:55 -07:00

help.c

builtin/help.c: speed up is_git_command() by checking for builtin commands first

2014-01-06 11:26:31 -08:00

index-pack.c

use xcalloc() to allocate zero-initialized memory

2014-07-21 10:30:21 -07:00

init-db.c

i18n: only extract comments marked with "TRANSLATORS:"

2014-04-17 11:09:56 -07:00

log.c

Merge branch 'jk/commit-buffer-length' into maint

2014-07-16 11:16:38 -07:00

ls-files.c

pathspec: pass directory indicator to match_pathspec_item()

2014-02-24 14:37:19 -08:00

ls-remote.c

builtin/ls-remote.c: rearrange xcalloc arguments

2014-05-27 14:00:43 -07:00

ls-tree.c

pathspec: rename match_pathspec_depth() to match_pathspec()

2014-02-24 14:37:14 -08:00

mailinfo.c

Merge branch 'rs/mailinfo-header-cmp' into maint

2014-06-25 11:48:23 -07:00

mailsplit.c

…

merge-base.c

Merge branch 'bm/merge-base-octopus-dedup' into maint

2014-02-13 13:38:59 -08:00

merge-file.c

Replace deprecated OPT_BOOLEAN by OPT_BOOL

2013-08-05 11:32:19 -07:00

merge-index.c

Convert "struct cache_entry *" to "const ..." wherever possible

2013-07-09 09:12:48 -07:00

merge-ours.c

…

merge-recursive.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

merge-tree.c

merge-tree: handle directory/empty conflict correctly

2013-05-06 22:17:00 -07:00

merge.c

commit_tree: take a pointer/len pair rather than a const strbuf

2014-06-12 10:29:41 -07:00

mktag.c

…

mktree.c

builtin/mktree.c: use ALLOC_GROW() in append_to_tree()

2014-03-03 14:54:45 -08:00

mv.c

Merge branch 'dt/merge-recursive-case-insensitive' into maint

2014-06-25 11:48:34 -07:00

name-rev.c

use wildmatch() directly without fnmatch() wrapper

2014-02-20 14:15:46 -08:00

notes.c

parse-options: multi-word argh should use dash to separate words

2014-03-24 10:43:34 -07:00

pack-objects.c

Merge branch 'jk/pack-bitmap'

2014-04-08 12:00:33 -07:00

pack-redundant.c

…

pack-refs.c

pack-refs: merge code from pack-refs.{c,h} into refs.{c,h}

2013-05-01 15:33:11 -07:00

patch-id.c

…

prune-packed.c

i18n: mark all progress lines for translation

2014-02-24 09:08:37 -08:00

prune.c

Merge branch 'mh/replace-refs-variable-rename'

2014-03-14 14:27:06 -07:00

push.c

Merge branch 'cc/starts-n-ends-with-endgame'

2014-03-07 15:18:28 -08:00

read-tree.c

C: have space around && and || operators

2013-10-16 10:26:39 -07:00

receive-pack.c

shallow: automatically clean up shallow tempfiles

2014-02-27 12:07:13 -08:00

reflog.c

use wildmatch() directly without fnmatch() wrapper

2014-02-20 14:15:46 -08:00

remote-ext.c

…

remote-fd.c

…

remote.c

Merge branch 'bg/xcalloc-nmemb-then-size' into maint

2014-07-22 10:25:17 -07:00

repack.c

Merge branch 'jk/repack-pack-keep-objects' into maint

2014-07-10 11:10:05 -07:00

replace.c

Merge branch 'mh/replace-refs-variable-rename'

2014-03-14 14:27:06 -07:00

rerere.c

rerere: fix for merge.conflictstyle

2014-04-30 10:30:02 -07:00

reset.c

convert logmsg_reencode to get_commit_buffer

2014-06-13 12:08:17 -07:00

rev-list.c

commit: record buffer length in cache

2014-06-13 12:09:38 -07:00

rev-parse.c

rev-parse --parseopt: option argument name hints

2014-03-23 17:28:03 -07:00

revert.c

parse-options: multi-word argh should use dash to separate words

2014-03-24 10:43:34 -07:00

rm.c

Merge branch 'nd/submodule-pathspec-ending-with-slash'

2014-02-27 14:01:15 -08:00

send-pack.c

Merge branch 'nd/shallow-clone'

2014-01-17 12:21:20 -08:00

shortlog.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

show-branch.c

use wildmatch() directly without fnmatch() wrapper

2014-02-20 14:15:46 -08:00

show-ref.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

stripspace.c

builtin/stripspace.c: fix broken indentation

2013-09-06 13:33:17 -07:00

symbolic-ref.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

tag.c

parse-options: multi-word argh should use dash to separate words

2014-03-24 10:43:34 -07:00

unpack-file.c

…

unpack-objects.c

Merge branch 'mh/replace-refs-variable-rename'

2014-03-14 14:27:06 -07:00

update-index.c

update-index: fix segfault with missing --cacheinfo argument

2014-06-04 11:02:55 -07:00

update-ref.c

update-ref: fail create operation over stdin if ref already exists

2014-04-02 10:40:43 -07:00

update-server-info.c

…

upload-archive.c

replace {pre,suf}fixcmp() with {starts,ends}_with()

2013-12-05 14:13:21 -08:00

var.c

…

verify-pack.c

…

verify-tag.c

…

write-tree.c

…