mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-21 10:29:16 -05:00
37d030d867
When `js/objects-larger-than-4gb-on-windows` widened the streaming, index-pack and unpack-objects code paths, in the interest of keeping the patches somewhat reasonably-sized, it left the public ODB API still typed in `unsigned long`. In particular `struct object_info::sizep` and the four wrappers built on top of it (`odb_read_object`, `odb_read_object_peeled`, `odb_read_object_info`, `odb_pretend_object`) still return the unpacked size through `unsigned long *`, so on Windows `cat-file -s` and the `git add` / `git status` paths for a >4 GiB blob silently cap at 4 GiB. Widen the field and the four wrappers. The previous commits already widened the `unpack_entry()` cascade and pack-objects' in-core size accessors, so most of the cascade arrives here with no further work: the temporary shims in `packed_object_info_with_index_pos()` and in `unpack_entry()`'s delta-base recovery path go away, the two `SET_SIZE(entry, cast_size_t_to_ulong(canonical_size))` calls in `check_object()` and the matching one in `drop_reused_delta()` collapse to plain `SET_SIZE`, and `oe_get_size_slow()`'s tail `cast_size_t_to_ulong()` is gone too. What remains narrow are the boundaries this series does not intend to touch: the diff, blame, textconv and fast-import machinery. Even so, this patch is unfortunately quite large. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
49 lines
1.2 KiB
C
49 lines
1.2 KiB
C
#define USE_THE_REPOSITORY_VARIABLE
|
|
|
|
#include "test-tool.h"
|
|
#include "hex.h"
|
|
#include "repository.h"
|
|
#include "odb.h"
|
|
#include "setup.h"
|
|
|
|
/*
|
|
* Prints the size of the object corresponding to the given hash in a specific
|
|
* gitdir. This is similar to "git -C gitdir cat-file -s", except that this
|
|
* exercises the code that accesses the object of an arbitrary repository that
|
|
* is not the_repository. ("git -C gitdir" makes it so that the_repository is
|
|
* the one in gitdir.)
|
|
*/
|
|
static void object_info(const char *gitdir, const char *oid_hex)
|
|
{
|
|
struct repository r;
|
|
struct object_id oid;
|
|
size_t size;
|
|
struct object_info oi = {.sizep = &size};
|
|
const char *p;
|
|
|
|
if (repo_init(&r, gitdir, NULL))
|
|
die("could not init repo");
|
|
if (parse_oid_hex_algop(oid_hex, &oid, &p, r.hash_algo))
|
|
die("could not parse oid");
|
|
if (odb_read_object_info_extended(r.objects, &oid, &oi, 0))
|
|
die("could not obtain object info");
|
|
printf("%d\n", (int) size);
|
|
|
|
repo_clear(&r);
|
|
}
|
|
|
|
int cmd__partial_clone(int argc, const char **argv)
|
|
{
|
|
setup_git_directory(the_repository);
|
|
|
|
if (argc < 4)
|
|
die("too few arguments");
|
|
|
|
if (!strcmp(argv[1], "object-info"))
|
|
object_info(argv[2], argv[3]);
|
|
else
|
|
die("invalid argument '%s'", argv[1]);
|
|
|
|
return 0;
|
|
}
|