mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 22:28:38 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
166 lines
3.1 KiB
C
166 lines
3.1 KiB
C
#include "../git-compat-util.h"
|
|
|
|
#include "system.h"
|
|
#include "basics.h"
|
|
#include "reftable-error.h"
|
|
#include "../lockfile.h"
|
|
#include "../trace.h"
|
|
#include "../tempfile.h"
|
|
#include "../write-or-die.h"
|
|
|
|
uint32_t reftable_rand(void)
|
|
{
|
|
return git_rand(CSPRNG_BYTES_INSECURE);
|
|
}
|
|
|
|
int tmpfile_from_pattern(struct reftable_tmpfile *out, const char *pattern)
|
|
{
|
|
struct tempfile *tempfile;
|
|
|
|
tempfile = mks_tempfile(pattern);
|
|
if (!tempfile)
|
|
return REFTABLE_IO_ERROR;
|
|
|
|
out->path = tempfile->filename.buf;
|
|
out->fd = tempfile->fd;
|
|
out->priv = tempfile;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int tmpfile_close(struct reftable_tmpfile *t)
|
|
{
|
|
struct tempfile *tempfile = t->priv;
|
|
int ret = close_tempfile_gently(tempfile);
|
|
t->fd = -1;
|
|
if (ret < 0)
|
|
return REFTABLE_IO_ERROR;
|
|
return 0;
|
|
}
|
|
|
|
int tmpfile_delete(struct reftable_tmpfile *t)
|
|
{
|
|
struct tempfile *tempfile = t->priv;
|
|
int ret = delete_tempfile(&tempfile);
|
|
*t = REFTABLE_TMPFILE_INIT;
|
|
if (ret < 0)
|
|
return REFTABLE_IO_ERROR;
|
|
return 0;
|
|
}
|
|
|
|
int tmpfile_rename(struct reftable_tmpfile *t, const char *path)
|
|
{
|
|
struct tempfile *tempfile = t->priv;
|
|
int ret = rename_tempfile(&tempfile, path);
|
|
*t = REFTABLE_TMPFILE_INIT;
|
|
if (ret < 0)
|
|
return REFTABLE_IO_ERROR;
|
|
return 0;
|
|
}
|
|
|
|
int flock_acquire(struct reftable_flock *l, const char *target_path,
|
|
long timeout_ms)
|
|
{
|
|
struct lock_file *lockfile;
|
|
int err;
|
|
|
|
lockfile = reftable_malloc(sizeof(*lockfile));
|
|
if (!lockfile)
|
|
return REFTABLE_OUT_OF_MEMORY_ERROR;
|
|
|
|
err = hold_lock_file_for_update_timeout(lockfile, target_path, LOCK_NO_DEREF,
|
|
timeout_ms);
|
|
if (err < 0) {
|
|
reftable_free(lockfile);
|
|
if (errno == EEXIST)
|
|
return REFTABLE_LOCK_ERROR;
|
|
return REFTABLE_IO_ERROR;
|
|
}
|
|
|
|
l->fd = get_lock_file_fd(lockfile);
|
|
l->path = get_lock_file_path(lockfile);
|
|
l->priv = lockfile;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int flock_close(struct reftable_flock *l)
|
|
{
|
|
struct lock_file *lockfile = l->priv;
|
|
int ret;
|
|
|
|
if (!lockfile)
|
|
return REFTABLE_API_ERROR;
|
|
|
|
ret = close_lock_file_gently(lockfile);
|
|
l->fd = -1;
|
|
if (ret < 0)
|
|
return REFTABLE_IO_ERROR;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int flock_release(struct reftable_flock *l)
|
|
{
|
|
struct lock_file *lockfile = l->priv;
|
|
int ret;
|
|
|
|
if (!lockfile)
|
|
return 0;
|
|
|
|
ret = rollback_lock_file(lockfile);
|
|
reftable_free(lockfile);
|
|
*l = REFTABLE_FLOCK_INIT;
|
|
if (ret < 0)
|
|
return REFTABLE_IO_ERROR;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int flock_commit(struct reftable_flock *l)
|
|
{
|
|
struct lock_file *lockfile = l->priv;
|
|
int ret;
|
|
|
|
if (!lockfile)
|
|
return REFTABLE_API_ERROR;
|
|
|
|
ret = commit_lock_file(lockfile);
|
|
reftable_free(lockfile);
|
|
*l = REFTABLE_FLOCK_INIT;
|
|
if (ret < 0)
|
|
return REFTABLE_IO_ERROR;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int reftable_fsync(int fd)
|
|
{
|
|
return fsync_component(FSYNC_COMPONENT_REFERENCE, fd);
|
|
}
|
|
|
|
uint64_t reftable_time_ms(void)
|
|
{
|
|
return getnanotime() / 1000000;
|
|
}
|
|
|
|
int reftable_mmap(struct reftable_mmap *out, int fd, size_t len)
|
|
{
|
|
void *data = xmmap_gently(NULL, len, PROT_READ, MAP_PRIVATE, fd, 0);
|
|
if (data == MAP_FAILED)
|
|
return REFTABLE_IO_ERROR;
|
|
|
|
out->data = data;
|
|
out->size = len;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int reftable_munmap(struct reftable_mmap *mmap)
|
|
{
|
|
if (munmap(mmap->data, mmap->size) < 0)
|
|
return REFTABLE_IO_ERROR;
|
|
memset(mmap, 0, sizeof(*mmap));
|
|
return 0;
|
|
}
|