mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-28 06:35:27 -05:00
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
175 lines
3.6 KiB
C
175 lines
3.6 KiB
C
/*
|
|
* Copyright 2020 Google LLC
|
|
*
|
|
* Use of this source code is governed by a BSD-style
|
|
* license that can be found in the LICENSE file or at
|
|
* https://developers.google.com/open-source/licenses/bsd
|
|
*/
|
|
|
|
#include "system.h"
|
|
|
|
#include "basics.h"
|
|
#include "blocksource.h"
|
|
#include "reftable-blocksource.h"
|
|
#include "reftable-error.h"
|
|
|
|
void block_source_release_data(struct reftable_block_data *data)
|
|
{
|
|
struct reftable_block_source source = data->source;
|
|
if (data && source.ops)
|
|
source.ops->release_data(source.arg, data);
|
|
data->data = NULL;
|
|
data->len = 0;
|
|
data->source.ops = NULL;
|
|
data->source.arg = NULL;
|
|
}
|
|
|
|
void block_source_close(struct reftable_block_source *source)
|
|
{
|
|
if (!source->ops) {
|
|
return;
|
|
}
|
|
|
|
source->ops->close(source->arg);
|
|
source->ops = NULL;
|
|
}
|
|
|
|
ssize_t block_source_read_data(struct reftable_block_source *source,
|
|
struct reftable_block_data *dest, uint64_t off,
|
|
uint32_t size)
|
|
{
|
|
ssize_t result = source->ops->read_data(source->arg, dest, off, size);
|
|
dest->source = *source;
|
|
return result;
|
|
}
|
|
|
|
uint64_t block_source_size(struct reftable_block_source *source)
|
|
{
|
|
return source->ops->size(source->arg);
|
|
}
|
|
|
|
static void reftable_buf_release_data(void *b REFTABLE_UNUSED, struct reftable_block_data *dest)
|
|
{
|
|
if (dest->len)
|
|
memset(dest->data, 0xff, dest->len);
|
|
reftable_free(dest->data);
|
|
}
|
|
|
|
static void reftable_buf_close(void *b REFTABLE_UNUSED)
|
|
{
|
|
}
|
|
|
|
static ssize_t reftable_buf_read_data(void *v, struct reftable_block_data *dest,
|
|
uint64_t off, uint32_t size)
|
|
{
|
|
struct reftable_buf *b = v;
|
|
assert(off + size <= b->len);
|
|
REFTABLE_CALLOC_ARRAY(dest->data, size);
|
|
if (!dest->data)
|
|
return -1;
|
|
memcpy(dest->data, b->buf + off, size);
|
|
dest->len = size;
|
|
return size;
|
|
}
|
|
|
|
static uint64_t reftable_buf_size(void *b)
|
|
{
|
|
return ((struct reftable_buf *)b)->len;
|
|
}
|
|
|
|
static struct reftable_block_source_vtable reftable_buf_vtable = {
|
|
.size = &reftable_buf_size,
|
|
.read_data = &reftable_buf_read_data,
|
|
.release_data = &reftable_buf_release_data,
|
|
.close = &reftable_buf_close,
|
|
};
|
|
|
|
void block_source_from_buf(struct reftable_block_source *bs,
|
|
struct reftable_buf *buf)
|
|
{
|
|
assert(!bs->ops);
|
|
bs->ops = &reftable_buf_vtable;
|
|
bs->arg = buf;
|
|
}
|
|
|
|
struct file_block_source {
|
|
struct reftable_mmap mmap;
|
|
};
|
|
|
|
static uint64_t file_size(void *b)
|
|
{
|
|
return ((struct file_block_source *)b)->mmap.size;
|
|
}
|
|
|
|
static void file_release_data(void *b REFTABLE_UNUSED, struct reftable_block_data *dest REFTABLE_UNUSED)
|
|
{
|
|
}
|
|
|
|
static void file_close(void *v)
|
|
{
|
|
struct file_block_source *b = v;
|
|
reftable_munmap(&b->mmap);
|
|
reftable_free(b);
|
|
}
|
|
|
|
static ssize_t file_read_data(void *v, struct reftable_block_data *dest, uint64_t off,
|
|
uint32_t size)
|
|
{
|
|
struct file_block_source *b = v;
|
|
assert(off + size <= b->mmap.size);
|
|
dest->data = (unsigned char *) b->mmap.data + off;
|
|
dest->len = size;
|
|
return size;
|
|
}
|
|
|
|
static struct reftable_block_source_vtable file_vtable = {
|
|
.size = &file_size,
|
|
.read_data = &file_read_data,
|
|
.release_data = &file_release_data,
|
|
.close = &file_close,
|
|
};
|
|
|
|
int reftable_block_source_from_file(struct reftable_block_source *bs,
|
|
const char *name)
|
|
{
|
|
struct file_block_source *p = NULL;
|
|
struct stat st;
|
|
int fd, err;
|
|
|
|
fd = open(name, O_RDONLY);
|
|
if (fd < 0) {
|
|
if (errno == ENOENT)
|
|
return REFTABLE_NOT_EXIST_ERROR;
|
|
err = -1;
|
|
goto out;
|
|
}
|
|
|
|
if (fstat(fd, &st) < 0) {
|
|
err = REFTABLE_IO_ERROR;
|
|
goto out;
|
|
}
|
|
|
|
REFTABLE_CALLOC_ARRAY(p, 1);
|
|
if (!p) {
|
|
err = REFTABLE_OUT_OF_MEMORY_ERROR;
|
|
goto out;
|
|
}
|
|
|
|
err = reftable_mmap(&p->mmap, fd, st.st_size);
|
|
if (err < 0)
|
|
goto out;
|
|
|
|
assert(!bs->ops);
|
|
bs->ops = &file_vtable;
|
|
bs->arg = p;
|
|
|
|
err = 0;
|
|
|
|
out:
|
|
if (fd >= 0)
|
|
close(fd);
|
|
if (err < 0)
|
|
reftable_free(p);
|
|
return err;
|
|
}
|