mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-30 00:43:38 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
38 lines
1.2 KiB
C
38 lines
1.2 KiB
C
#ifndef WIN32_PATH_UTILS_H
|
|
#define WIN32_PATH_UTILS_H
|
|
|
|
int win32_has_dos_drive_prefix(const char *path);
|
|
#define has_dos_drive_prefix win32_has_dos_drive_prefix
|
|
|
|
int win32_skip_dos_drive_prefix(char **path);
|
|
#define skip_dos_drive_prefix win32_skip_dos_drive_prefix
|
|
#define is_dir_sep is_xplatform_dir_sep
|
|
static inline char *win32_find_last_dir_sep(const char *path)
|
|
{
|
|
char *ret = NULL;
|
|
for (; *path; ++path)
|
|
if (is_dir_sep(*path))
|
|
ret = (char *)path;
|
|
return ret;
|
|
}
|
|
#define find_last_dir_sep win32_find_last_dir_sep
|
|
static inline int win32_has_dir_sep(const char *path)
|
|
{
|
|
/*
|
|
* See how long the non-separator part of the given path is, and
|
|
* if and only if it covers the whole path (i.e. path[len] is NUL),
|
|
* there is no separator in the path---otherwise there is a separator.
|
|
*/
|
|
size_t len = strcspn(path, "/\\");
|
|
return !!path[len];
|
|
}
|
|
#define has_dir_sep(path) win32_has_dir_sep(path)
|
|
int win32_offset_1st_component(const char *path);
|
|
#define offset_1st_component win32_offset_1st_component
|
|
int win32_fspathcmp(const char *a, const char *b);
|
|
#define fspathcmp win32_fspathcmp
|
|
int win32_fspathncmp(const char *a, const char *b, size_t count);
|
|
#define fspathncmp win32_fspathncmp
|
|
|
|
#endif
|