mirror of
https://github.com/git-for-windows/git.git
synced 2025-12-12 04:41:35 -06:00
596184786c
Callers which want to know how many items are in an oidmap have to look at the underlying hashmap struct, leaking an implementation detail. Let's provide a type-appropriate wrapper and use it. Note in the call from lookup_replace_object(), the caller was actually looking at the hashmap's tablesize parameter (the allocated size of the table) rather than hashmap_get_size(), the number of items in the table. This probably should have been checking the number of items all along, but the two are functionally equivalent here since we only add to the map and never remove anything. Thus if there was any allocation, it was because there is at least one item. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
64 lines
2.1 KiB
C
64 lines
2.1 KiB
C
#ifndef REPLACE_OBJECT_H
|
|
#define REPLACE_OBJECT_H
|
|
|
|
#include "oidmap.h"
|
|
#include "repository.h"
|
|
#include "object-store.h"
|
|
|
|
struct replace_object {
|
|
struct oidmap_entry original;
|
|
struct object_id replacement;
|
|
};
|
|
|
|
void prepare_replace_object(struct repository *r);
|
|
|
|
/*
|
|
* This internal function is only declared here for the benefit of
|
|
* lookup_replace_object(). Please do not call it directly.
|
|
*/
|
|
const struct object_id *do_lookup_replace_object(struct repository *r,
|
|
const struct object_id *oid);
|
|
|
|
/*
|
|
* Some commands disable replace-refs unconditionally, and otherwise each
|
|
* repository could alter the core.useReplaceRefs config value.
|
|
*
|
|
* Return 1 if and only if all of the following are true:
|
|
*
|
|
* a. disable_replace_refs() has not been called.
|
|
* b. GIT_NO_REPLACE_OBJECTS is unset or zero.
|
|
* c. the given repository does not have core.useReplaceRefs=false.
|
|
*/
|
|
int replace_refs_enabled(struct repository *r);
|
|
|
|
/*
|
|
* If object sha1 should be replaced, return the replacement object's
|
|
* name (replaced recursively, if necessary). The return value is
|
|
* either sha1 or a pointer to a permanently-allocated value. When
|
|
* object replacement is suppressed, always return sha1.
|
|
*
|
|
* Note: some thread debuggers might point a data race on the
|
|
* replace_map_initialized reading in this function. However, we know there's no
|
|
* problem in the value being updated by one thread right after another one read
|
|
* it here (and it should be written to only once, anyway).
|
|
*/
|
|
static inline const struct object_id *lookup_replace_object(struct repository *r,
|
|
const struct object_id *oid)
|
|
{
|
|
if (!replace_refs_enabled(r) ||
|
|
(r->objects->replace_map_initialized &&
|
|
oidmap_get_size(r->objects->replace_map) == 0))
|
|
return oid;
|
|
return do_lookup_replace_object(r, oid);
|
|
}
|
|
|
|
/*
|
|
* Some commands override config and environment settings for using
|
|
* replace references. Use this method to disable the setting and ensure
|
|
* those other settings will not override this choice. This applies
|
|
* globally to all in-process repositories.
|
|
*/
|
|
void disable_replace_refs(void);
|
|
|
|
#endif /* REPLACE_OBJECT_H */
|