mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 22:28:38 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
121 lines
3.1 KiB
C
121 lines
3.1 KiB
C
#include "git-compat-util.h"
|
|
#include "trace2/tr2_tgt.h"
|
|
#include "trace2/tr2_tls.h"
|
|
#include "trace2/tr2_ctr.h"
|
|
|
|
/*
|
|
* A global counter block to aggregate values from the partial sums
|
|
* from each thread.
|
|
*/
|
|
static struct tr2_counter_block final_counter_block; /* access under tr2tls_mutex */
|
|
|
|
/*
|
|
* Define metadata for each global counter.
|
|
*
|
|
* This array must match the "enum trace2_counter_id" and the values
|
|
* in "struct tr2_counter_block.counter[*]".
|
|
*/
|
|
static struct tr2_counter_metadata tr2_counter_metadata[TRACE2_NUMBER_OF_COUNTERS] = {
|
|
[TRACE2_COUNTER_ID_TEST1] = {
|
|
.category = "test",
|
|
.name = "test1",
|
|
.want_per_thread_events = 0,
|
|
},
|
|
[TRACE2_COUNTER_ID_TEST2] = {
|
|
.category = "test",
|
|
.name = "test2",
|
|
.want_per_thread_events = 1,
|
|
},
|
|
[TRACE2_COUNTER_ID_PACKED_REFS_JUMPS] = {
|
|
.category = "packed-refs",
|
|
.name = "jumps_made",
|
|
.want_per_thread_events = 0,
|
|
},
|
|
[TRACE2_COUNTER_ID_REFTABLE_RESEEKS] = {
|
|
.category = "reftable",
|
|
.name = "reseeks_made",
|
|
.want_per_thread_events = 0,
|
|
},
|
|
[TRACE2_COUNTER_ID_FSYNC_WRITEOUT_ONLY] = {
|
|
.category = "fsync",
|
|
.name = "writeout-only",
|
|
.want_per_thread_events = 0,
|
|
},
|
|
[TRACE2_COUNTER_ID_FSYNC_HARDWARE_FLUSH] = {
|
|
.category = "fsync",
|
|
.name = "hardware-flush",
|
|
.want_per_thread_events = 0,
|
|
},
|
|
|
|
/* Add additional metadata before here. */
|
|
};
|
|
|
|
void tr2_counter_increment(enum trace2_counter_id cid, uint64_t value)
|
|
{
|
|
struct tr2tls_thread_ctx *ctx = tr2tls_get_self();
|
|
struct tr2_counter *c = &ctx->counter_block.counter[cid];
|
|
|
|
c->value += value;
|
|
|
|
ctx->used_any_counter = 1;
|
|
if (tr2_counter_metadata[cid].want_per_thread_events)
|
|
ctx->used_any_per_thread_counter = 1;
|
|
}
|
|
|
|
void tr2_update_final_counters(void)
|
|
{
|
|
struct tr2tls_thread_ctx *ctx = tr2tls_get_self();
|
|
enum trace2_counter_id cid;
|
|
|
|
if (!ctx->used_any_counter)
|
|
return;
|
|
|
|
/*
|
|
* Access `final_counter_block` requires holding `tr2tls_mutex`.
|
|
* We assume that our caller is holding the lock.
|
|
*/
|
|
|
|
for (cid = 0; cid < TRACE2_NUMBER_OF_COUNTERS; cid++) {
|
|
struct tr2_counter *c_final = &final_counter_block.counter[cid];
|
|
const struct tr2_counter *c = &ctx->counter_block.counter[cid];
|
|
|
|
c_final->value += c->value;
|
|
}
|
|
}
|
|
|
|
void tr2_emit_per_thread_counters(tr2_tgt_evt_counter_t *fn_apply)
|
|
{
|
|
struct tr2tls_thread_ctx *ctx = tr2tls_get_self();
|
|
enum trace2_counter_id cid;
|
|
|
|
if (!ctx->used_any_per_thread_counter)
|
|
return;
|
|
|
|
/*
|
|
* For each counter, if the counter wants per-thread events
|
|
* and this thread used it (the value is non-zero), emit it.
|
|
*/
|
|
for (cid = 0; cid < TRACE2_NUMBER_OF_COUNTERS; cid++)
|
|
if (tr2_counter_metadata[cid].want_per_thread_events &&
|
|
ctx->counter_block.counter[cid].value)
|
|
fn_apply(&tr2_counter_metadata[cid],
|
|
&ctx->counter_block.counter[cid],
|
|
0);
|
|
}
|
|
|
|
void tr2_emit_final_counters(tr2_tgt_evt_counter_t *fn_apply)
|
|
{
|
|
enum trace2_counter_id cid;
|
|
|
|
/*
|
|
* Access `final_counter_block` requires holding `tr2tls_mutex`.
|
|
* We assume that our caller is holding the lock.
|
|
*/
|
|
|
|
for (cid = 0; cid < TRACE2_NUMBER_OF_COUNTERS; cid++)
|
|
if (final_counter_block.counter[cid].value)
|
|
fn_apply(&tr2_counter_metadata[cid],
|
|
&final_counter_block.counter[cid],
|
|
1);
|
|
}
|