mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-28 18:55:47 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
126 lines
2.9 KiB
C
126 lines
2.9 KiB
C
#include "git-compat-util.h"
|
|
#include "lockfile.h"
|
|
#include "unix-socket.h"
|
|
#include "unix-stream-server.h"
|
|
|
|
#define DEFAULT_LOCK_TIMEOUT (100)
|
|
|
|
/*
|
|
* Try to connect to a unix domain socket at `path` (if it exists) and
|
|
* see if there is a server listening.
|
|
*
|
|
* We don't know if the socket exists, whether a server died and
|
|
* failed to cleanup, or whether we have a live server listening, so
|
|
* we "poke" it.
|
|
*
|
|
* We immediately hangup without sending/receiving any data because we
|
|
* don't know anything about the protocol spoken and don't want to
|
|
* block while writing/reading data. It is sufficient to just know
|
|
* that someone is listening.
|
|
*/
|
|
static int is_another_server_alive(const char *path,
|
|
const struct unix_stream_listen_opts *opts)
|
|
{
|
|
int fd = unix_stream_connect(path, opts->disallow_chdir);
|
|
if (fd >= 0) {
|
|
close(fd);
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int unix_ss_create(const char *path,
|
|
const struct unix_stream_listen_opts *opts,
|
|
long timeout_ms,
|
|
struct unix_ss_socket **new_server_socket)
|
|
{
|
|
struct lock_file lock = LOCK_INIT;
|
|
int fd_socket;
|
|
struct unix_ss_socket *server_socket;
|
|
|
|
*new_server_socket = NULL;
|
|
|
|
if (timeout_ms < 0)
|
|
timeout_ms = DEFAULT_LOCK_TIMEOUT;
|
|
|
|
/*
|
|
* Create a lock at "<path>.lock" if we can.
|
|
*/
|
|
if (hold_lock_file_for_update_timeout(&lock, path, 0, timeout_ms) < 0)
|
|
return -1;
|
|
|
|
/*
|
|
* If another server is listening on "<path>" give up. We do not
|
|
* want to create a socket and steal future connections from them.
|
|
*/
|
|
if (is_another_server_alive(path, opts)) {
|
|
rollback_lock_file(&lock);
|
|
errno = EADDRINUSE;
|
|
return -2;
|
|
}
|
|
|
|
/*
|
|
* Create and bind to a Unix domain socket at "<path>".
|
|
*/
|
|
fd_socket = unix_stream_listen(path, opts);
|
|
if (fd_socket < 0) {
|
|
int saved_errno = errno;
|
|
rollback_lock_file(&lock);
|
|
errno = saved_errno;
|
|
return -1;
|
|
}
|
|
|
|
server_socket = xcalloc(1, sizeof(*server_socket));
|
|
server_socket->path_socket = strdup(path);
|
|
server_socket->fd_socket = fd_socket;
|
|
lstat(path, &server_socket->st_socket);
|
|
|
|
*new_server_socket = server_socket;
|
|
|
|
/*
|
|
* Always rollback (just delete) "<path>.lock" because we already created
|
|
* "<path>" as a socket and do not want to commit_lock to do the atomic
|
|
* rename trick.
|
|
*/
|
|
rollback_lock_file(&lock);
|
|
|
|
return 0;
|
|
}
|
|
|
|
void unix_ss_free(struct unix_ss_socket *server_socket)
|
|
{
|
|
if (!server_socket)
|
|
return;
|
|
|
|
if (server_socket->fd_socket >= 0) {
|
|
if (!unix_ss_was_stolen(server_socket))
|
|
unlink(server_socket->path_socket);
|
|
close(server_socket->fd_socket);
|
|
}
|
|
|
|
free(server_socket->path_socket);
|
|
free(server_socket);
|
|
}
|
|
|
|
int unix_ss_was_stolen(struct unix_ss_socket *server_socket)
|
|
{
|
|
struct stat st_now;
|
|
|
|
if (!server_socket)
|
|
return 0;
|
|
|
|
if (lstat(server_socket->path_socket, &st_now) == -1)
|
|
return 1;
|
|
|
|
if (st_now.st_ino != server_socket->st_socket.st_ino)
|
|
return 1;
|
|
if (st_now.st_dev != server_socket->st_socket.st_dev)
|
|
return 1;
|
|
|
|
if (!S_ISSOCK(st_now.st_mode))
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|