mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 11:47:49 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
115 lines
3.0 KiB
C
115 lines
3.0 KiB
C
#include "git-compat-util.h"
|
|
#include "hex.h"
|
|
#include "strbuf.h"
|
|
#include "trace2/tr2_tbuf.h"
|
|
#include "trace2/tr2_sid.h"
|
|
|
|
#define TR2_ENVVAR_PARENT_SID "GIT_TRACE2_PARENT_SID"
|
|
|
|
static struct strbuf tr2sid_buf = STRBUF_INIT;
|
|
static int tr2sid_nr_git_parents;
|
|
|
|
/*
|
|
* Compute the final component of the SID representing the current process.
|
|
* This should uniquely identify the process and be a valid filename (to
|
|
* allow writing trace2 data to per-process files). It should also be fixed
|
|
* length for possible use as a database key.
|
|
*
|
|
* "<yyyymmdd>T<hhmmss>.<fraction>Z-<host>-<process>"
|
|
*
|
|
* where <host> is a 9 character string:
|
|
* "H<first_8_chars_of_sha1_of_hostname>"
|
|
* "Localhost" when no hostname.
|
|
*
|
|
* where <process> is a 9 character string containing the least significant
|
|
* 32 bits in the process-id.
|
|
* "P<pid>"
|
|
* (This is an abribrary choice. On most systems pid_t is a 32 bit value,
|
|
* so limit doesn't matter. On larger systems, a truncated value is fine
|
|
* for our purposes here.)
|
|
*/
|
|
static void tr2_sid_append_my_sid_component(void)
|
|
{
|
|
const struct git_hash_algo *algo = &hash_algos[GIT_HASH_SHA1];
|
|
struct tr2_tbuf tb_now;
|
|
struct git_hash_ctx ctx;
|
|
pid_t pid = getpid();
|
|
unsigned char hash[GIT_MAX_RAWSZ + 1];
|
|
char hex[GIT_MAX_HEXSZ + 1];
|
|
char hostname[HOST_NAME_MAX + 1];
|
|
|
|
tr2_tbuf_utc_datetime(&tb_now);
|
|
strbuf_addstr(&tr2sid_buf, tb_now.buf);
|
|
|
|
strbuf_addch(&tr2sid_buf, '-');
|
|
if (xgethostname(hostname, sizeof(hostname)))
|
|
strbuf_add(&tr2sid_buf, "Localhost", 9);
|
|
else {
|
|
algo->init_fn(&ctx);
|
|
git_hash_update(&ctx, hostname, strlen(hostname));
|
|
git_hash_final(hash, &ctx);
|
|
hash_to_hex_algop_r(hex, hash, algo);
|
|
strbuf_addch(&tr2sid_buf, 'H');
|
|
strbuf_add(&tr2sid_buf, hex, 8);
|
|
}
|
|
|
|
strbuf_addf(&tr2sid_buf, "-P%08"PRIx32, (uint32_t)pid);
|
|
}
|
|
|
|
/*
|
|
* Compute a "unique" session id (SID) for the current process. This allows
|
|
* all events from this process to have a single label (much like a PID).
|
|
*
|
|
* Export this into our environment so that all child processes inherit it.
|
|
*
|
|
* If we were started by another git instance, use our parent's SID as a
|
|
* prefix. (This lets us track parent/child relationships even if there
|
|
* is an intermediate shell process.)
|
|
*
|
|
* Additionally, count the number of nested git processes.
|
|
*/
|
|
static void tr2_sid_compute(void)
|
|
{
|
|
const char *parent_sid;
|
|
|
|
if (tr2sid_buf.len)
|
|
return;
|
|
|
|
parent_sid = getenv(TR2_ENVVAR_PARENT_SID);
|
|
if (parent_sid && *parent_sid) {
|
|
const char *p;
|
|
for (p = parent_sid; *p; p++)
|
|
if (*p == '/')
|
|
tr2sid_nr_git_parents++;
|
|
|
|
strbuf_addstr(&tr2sid_buf, parent_sid);
|
|
strbuf_addch(&tr2sid_buf, '/');
|
|
tr2sid_nr_git_parents++;
|
|
}
|
|
|
|
tr2_sid_append_my_sid_component();
|
|
|
|
setenv(TR2_ENVVAR_PARENT_SID, tr2sid_buf.buf, 1);
|
|
}
|
|
|
|
const char *tr2_sid_get(void)
|
|
{
|
|
if (!tr2sid_buf.len)
|
|
tr2_sid_compute();
|
|
|
|
return tr2sid_buf.buf;
|
|
}
|
|
|
|
int tr2_sid_depth(void)
|
|
{
|
|
if (!tr2sid_buf.len)
|
|
tr2_sid_compute();
|
|
|
|
return tr2sid_nr_git_parents;
|
|
}
|
|
|
|
void tr2_sid_release(void)
|
|
{
|
|
strbuf_release(&tr2sid_buf);
|
|
}
|