mirror of
https://github.com/git-for-windows/git.git
synced 2026-06-27 22:28:38 -05:00
9759608622
The Git project is not exactly the easiest project to get started in: it's written in C and POSIX shell, with bits of Perl, Rust and other languages sprinkled into it. On top of that, the project has grown somewhat organically over time, making the codebase hard to navigate. These are problems that we're aware of, and there have been and still are efforts to clean up some of the technical debt that is natural to exist an a project that is more than 20 years old. Furthermore, we provide resources to newcomers that help them out like our coding guidelines, code of conduct or "MyFirstContribution.adoc". But there is a rather practical problem: finding your way around in our project's tree is not easy. Doing a directory listing in the top-level directory will present you with more than 550 files, which makes it extremely hard for a newcomer to figure out what files they are even supposed to look at. This makes the onboarding experience somewhat harder than it really needs to be. This isn't only a problem for newcomers though, as I myself struggle to find the files I am looking for because of the sheer number of files. Besides the problem of discoverability it also creates a problem of structure. It is not obvious at all which files are part of "libgit.a" and which files are only linked into our final executables. So while we have this split in our build systems, that split is not evident at all in our tree. Introduce a new "lib/" directory and move all of our sources for "libgit.a" into it to fix these issues. It makes the split we have evident and reduces the number of files in our top-level tree from 550 files to ~80 files. This is still a lot of files, but it's significantly easier to navigate already. Furthermore, we can further iterate after this step and think about introducing a better structure for remaining files, as well. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
135 lines
3.1 KiB
C
135 lines
3.1 KiB
C
#define USE_THE_REPOSITORY_VARIABLE
|
|
|
|
#include "git-compat-util.h"
|
|
#include "environment.h"
|
|
#include "statinfo.h"
|
|
#include "repository.h"
|
|
|
|
/*
|
|
* Munge st_size into an unsigned int.
|
|
*/
|
|
static unsigned int munge_st_size(off_t st_size) {
|
|
unsigned int sd_size = st_size;
|
|
|
|
/*
|
|
* If the file is an exact multiple of 4 GiB, modify the value so it
|
|
* doesn't get marked as racily clean (zero).
|
|
*/
|
|
if (!sd_size && st_size)
|
|
return 0x80000000;
|
|
else
|
|
return sd_size;
|
|
}
|
|
|
|
void fill_stat_data(struct stat_data *sd, struct stat *st)
|
|
{
|
|
sd->sd_ctime.sec = (unsigned int)st->st_ctime;
|
|
sd->sd_mtime.sec = (unsigned int)st->st_mtime;
|
|
sd->sd_ctime.nsec = ST_CTIME_NSEC(*st);
|
|
sd->sd_mtime.nsec = ST_MTIME_NSEC(*st);
|
|
sd->sd_dev = st->st_dev;
|
|
sd->sd_ino = st->st_ino;
|
|
sd->sd_uid = st->st_uid;
|
|
sd->sd_gid = st->st_gid;
|
|
sd->sd_size = munge_st_size(st->st_size);
|
|
}
|
|
|
|
static void set_times(struct stat *st, const struct stat_data *sd)
|
|
{
|
|
st->st_ctime = sd->sd_ctime.sec;
|
|
st->st_mtime = sd->sd_mtime.sec;
|
|
#ifdef NO_NSEC
|
|
; /* nothing */
|
|
#else
|
|
#ifdef USE_ST_TIMESPEC
|
|
st->st_ctimespec.tv_nsec = sd->sd_ctime.nsec;
|
|
st->st_mtimespec.tv_nsec = sd->sd_mtime.nsec;
|
|
#else
|
|
st->st_ctim.tv_nsec = sd->sd_ctime.nsec;
|
|
st->st_mtim.tv_nsec = sd->sd_mtime.nsec;
|
|
#endif
|
|
#endif
|
|
}
|
|
|
|
void fake_lstat_data(const struct stat_data *sd, struct stat *st)
|
|
{
|
|
set_times(st, sd);
|
|
st->st_dev = sd->sd_dev;
|
|
st->st_ino = sd->sd_ino;
|
|
st->st_uid = sd->sd_uid;
|
|
st->st_gid = sd->sd_gid;
|
|
st->st_size = sd->sd_size;
|
|
}
|
|
|
|
int match_stat_data(const struct stat_data *sd, struct stat *st)
|
|
{
|
|
int changed = 0;
|
|
struct repo_config_values *cfg = repo_config_values(the_repository);
|
|
|
|
if (sd->sd_mtime.sec != (unsigned int)st->st_mtime)
|
|
changed |= MTIME_CHANGED;
|
|
if (cfg->trust_ctime && cfg->check_stat &&
|
|
sd->sd_ctime.sec != (unsigned int)st->st_ctime)
|
|
changed |= CTIME_CHANGED;
|
|
|
|
#ifdef USE_NSEC
|
|
if (cfg->check_stat && sd->sd_mtime.nsec != ST_MTIME_NSEC(*st))
|
|
changed |= MTIME_CHANGED;
|
|
if (cfg->trust_ctime && cfg->check_stat &&
|
|
sd->sd_ctime.nsec != ST_CTIME_NSEC(*st))
|
|
changed |= CTIME_CHANGED;
|
|
#endif
|
|
|
|
if (cfg->check_stat) {
|
|
if (sd->sd_uid != (unsigned int) st->st_uid ||
|
|
sd->sd_gid != (unsigned int) st->st_gid)
|
|
changed |= OWNER_CHANGED;
|
|
if (sd->sd_ino != (unsigned int) st->st_ino)
|
|
changed |= INODE_CHANGED;
|
|
}
|
|
|
|
#ifdef USE_STDEV
|
|
/*
|
|
* st_dev breaks on network filesystems where different
|
|
* clients will have different views of what "device"
|
|
* the filesystem is on
|
|
*/
|
|
if (cfg->check_stat && sd->sd_dev != (unsigned int) st->st_dev)
|
|
changed |= INODE_CHANGED;
|
|
#endif
|
|
|
|
if (sd->sd_size != munge_st_size(st->st_size))
|
|
changed |= DATA_CHANGED;
|
|
|
|
return changed;
|
|
}
|
|
|
|
void stat_validity_clear(struct stat_validity *sv)
|
|
{
|
|
FREE_AND_NULL(sv->sd);
|
|
}
|
|
|
|
int stat_validity_check(struct stat_validity *sv, const char *path)
|
|
{
|
|
struct stat st;
|
|
|
|
if (stat(path, &st) < 0)
|
|
return sv->sd == NULL;
|
|
if (!sv->sd)
|
|
return 0;
|
|
return S_ISREG(st.st_mode) && !match_stat_data(sv->sd, &st);
|
|
}
|
|
|
|
void stat_validity_update(struct stat_validity *sv, int fd)
|
|
{
|
|
struct stat st;
|
|
|
|
if (fstat(fd, &st) < 0 || !S_ISREG(st.st_mode))
|
|
stat_validity_clear(sv);
|
|
else {
|
|
if (!sv->sd)
|
|
CALLOC_ARRAY(sv->sd, 1);
|
|
fill_stat_data(sv->sd, &st);
|
|
}
|
|
}
|